Skip to content

Review backlog (docs-currency): IGNORED_FAILED_UNITS_IN_VM lists not covered by inventory #1048

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #1040.

PR: #1040 (#1040)
Perspective: docs-currency
Severity: low (P3)
Evidence: tests/smoke/features/steps/system_health_steps.py:21 (

)
Finding: IGNORED_FAILED_UNITS_IN_VM lists not covered by inventory

system_health_steps.py:21 and tests/kde-smoke/features/steps/steps.py:35 hard-code the bogus cups.browsed.service name the inventory documents, and tolerate failed units (tuned, bootloader-update, ...) as a second omission mechanism the inventory does not cover. Backlog: reference the inventory from those lists or fold tolerated-failed units into it.

Fingerprint: d2ccddd7a65cabea5b53338ea1602df584dd8bd1cc325938b2830296dab763d6

filed by Hive review backlog

Activity

  1. Danathar commented on Oct 28, 2026

    @Danathar
    Contributor

    Triage: accepted (kind/documentation). Valid docs-currency finding.

  2. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🌱 Good first issue — bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-projectbluefin-knuckle-gjvq picked this issue as a good place to start because:

    • scoped to two packages (tests/kde-smoke, tests/smoke)
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-projectbluefin-common-nmq5.hive.hivecommons.dev/contribute?issue=projectbluefin%2Ftestsuite%231048 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #1048 — that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #1048 in github.com/projectbluefin/testsuite (https://github.com/projectbluefin/testsuite/issues/1048). First open https://hosted-projectbluefin-common-nmq5.hive.hivecommons.dev/contribute?issue=projectbluefin%2Ftestsuite%231048 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #1048' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/projectbluefin/testsuite/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-projectbluefin-common-nmq5.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.

  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same file, possibly a different problem). Raised in the Hive review of PR #1056 (#1056) and folded into this issue because it cites docs/skills/test-authoring/gnome/SKILL.md, which this issue already covers. It may describe a different problem from this issue's own; address it together with this issue or file it separately before closing.

    Review backlog (docs-currency): SKILL.md still describes a per-name tree.root.application() fallback for _firefox_app

    • SKILL.md still describes a per-name tree.root.application() fallback for _firefox_app (docs/skills/test-authoring/gnome/SKILL.md:163)

    Perspective: docs-currency
    Severity: low (P3)
    Evidence: docs/skills/test-authoring/gnome/SKILL.md:163 (

    1. Resolve the app with `_firefox_app()`, which first scans the live `tree.root.applications()` list matching `FIREFOX_APP_NAMES` case-insensitively, then falls back to per-name `tree.root.application()` lookups, polling until a short elapsed-time deadline (3 s by default). Keep `"Firefox"` (the name GNOME 50 registers) first in `FIREFOX_APP_NAMES` so the fallback lookup hits on its first attempt.
    )
    Finding: SKILL.md still describes a per-name tree.root.application() fallback for _firefox_app

    docs/skills/test-authoring/gnome/SKILL.md:163 says _firefox_app 'falls back to per-name tree.root.application() lookups'; firefox_steps.py:113-114 explicitly has no such fallback and the new atspi.md:60-62 guidance forbids it. Stale text should be rewritten to describe snapshot-only lookup.

    Fingerprint: 200eb06329d97610ab10ee7a37f9f616ffb149782281b022f25535481f16266b

    filed by Hive review backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions