Repository navigation
Conversation
Pin quay.io/argoproj/argocd:v2.12.3 to sha256:68894064bc381c19ea951029510aa614bd26bf46c2ec65ea445c7d8d095a9417 to guarantee image immutability and supply-chain integrity for control-plane GitOps manifests. Partially addresses #74. Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
d447ea5 to
c35c1f1
Compare
hanthor
left a comment
There was a problem hiding this comment.
Digest verified against live quay.io — approving
$ curl -H "Accept: application/vnd.oci.image.index.v1+json" \
https://quay.io/v2/argoproj/argocd/manifests/v2.12.3
docker-content-digest: sha256:68894064bc381c19ea951029510aa614bd26bf46c2ec65ea445c7d8d095a9417
Byte-identical to the diff. The tag is preserved alongside the digest (v2.12.3@sha256:…), which is the right form — the digest is what's enforced, the tag stays for human legibility, and they can't silently disagree because the registry rejects the pull if they do.
One line, build and unit both green, and it closes a mutable tag in a manifest that runs with cluster privileges.
Generated by Claude Code
|
Baseline triage: the same check is red on Tracked as one incident in #175. No action needed on this branch — deferring rather than retrying until the baseline is green. — hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.78 |
|
Author note from the PR-triage sweep — I cannot review my own PR, so recording the state explicitly. Outstanding: one independent approval. This has one live approval from @hanthor on the current head CI: Two open PRs address that repo-wide breakage: #173 fixes the I deliberately did not touch this branch. Any push would dismiss @hanthor's approval — I have now confirmed that empirically, having watched Reviewer note if it helps: the change pins |
There was a problem hiding this comment.
intent-alignment
Partial fix, body overclaims. The PR says it "Addresses finding in #74", but the diff (files/k0s/manifests/argocd/install.yaml:44) only covers a slice of recommendation 1 of that issue. #74's primary asks were: (1) upgrade Argo CD off the EOL v2.12.3 line (known unpatched CVEs) and pin by digest, (2) address argocd-server --insecure (still present at install.yaml:45), (3) digest-pin the kubestellar/postgres images. This change pins the digest of the same EOL image — cementing the known-vulnerable version — and touches none of the rest. As a standalone hardening step it's fine and the digest is genuine (verified sha256:6889...9417 == quay.io v2.12.3 manifest digest), but #74 should not be considered addressed; please reword to "partially addresses" and keep #74 open, or extend the PR.
No findings from: security, style, docs-currency.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
|
Closing as superseded by #210. `files/k0s/manifests/argocd/install.yaml` is deleted. #210 moves to Argo CD Core, which has no `argocd-server` component at all — so the `--insecure` API server exposure in #74 has no surface left. The one Argo image that remains (`files/cluster/seed/15-gitd/deployment.yaml`) is pinned by digest: `quay.io/argoproj/argocd@sha256:dd3f47d5…`. Right instinct, and the mutable-tag rule carries forward. |
Security Hardening
Pin
quay.io/argoproj/argocd:v2.12.3to digestsha256:68894064bc381c19ea951029510aa614bd26bf46c2ec65ea445c7d8d095a9417infiles/k0s/manifests/argocd/install.yamlto prevent mutable tag drift and ensure supply-chain integrity for control-plane GitOps deployments.This partially addresses #74 by digest-pinning the argocd-server image. #74 remains open for the Argo CD version upgrade,
argocd-server --insecure, and the other mutable images called out there.Verification
pytest tests/unit(Passed)python3 .github/scripts/docs-checks.py(Passed)just validate(Passed)