Repository navigation
Conversation
Root ships locked ("!unprovisioned"). Ignition users entries and the
ssh.authorized_keys.root credential install a key without touching the
password, so root stays locked, and sshd without PAM refuses a locked
account even for keys ("User root not allowed because account is
locked"). The documented ssh root@<node> path was refused on netboot,
Booty and credential-provisioned nodes.
UsePAM yes hands the account check to FSDK's /etc/pam.d/sshd, which
ignores the password field. PasswordAuthentication and
KbdInteractiveAuthentication stay off, so PAM is never asked for a
password.
The dogfood SSH login no longer unlocks root first, and asserts root is
still locked when the key login succeeds.
Assisted-by: Claude via Claude Code
Co-Authored-By: Claude Code <noreply@anthropic.com>
These three drop-ins lived in the factory /etc. systemd-tmpfiles copies factory files with C, which never overwrites, and a disk install keeps /etc across A/B updates, so an installed node kept the copy it first booted. No change to them, including the UsePAM fix, could reach it. resolved, system.conf and the prompt already moved to /usr for this. - sysctl and journald: written to /usr/lib/sysctl.d and /usr/lib/systemd/journald.conf.d, which both read directly. - sshd: installed in /usr/lib/bluefin/sshd_config.d and linked into /etc/ssh/sshd_config.d by a tmpfiles L line. sshd has no /usr config directory, and L leaves an operator's own file of that name alone. The main sshd_config, which only includes sshd_config.d, stays in the factory /etc. - bluefin-migrate-etc-vendor (bluefin-host) runs once on installed nodes, before systemd-tmpfiles-setup, and removes each old copy only while it is byte-identical to a version a release shipped (hashes from every v26.09+ tag). An edited copy stays and keeps winning. Assisted-by: Claude via Claude Code Co-Authored-By: Claude Code <noreply@anthropic.com>
Collaborator
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Ready for a human merge: verdict approved The hive never approves on your behalf: approve and merge it on GitHub if you accept it. |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Installed servers never receive changes to three of the image's own settings files: the SSH server settings, a kernel console setting and a journal setting. Those files are copied into
/etconce, on the first boot, and an installed disk keeps/etcacross updates, so the copy stays as it was on that first boot. This moves them into the read-only system image, which every update replaces, and adds a one-time cleanup of the old copies on servers that already have them. A copy an operator has edited is left alone.Depends on #700. This branch is stacked on it: the first commit here is #700's, so please review and merge that one first.
Why
elements/oci/bluefin-server-usr.bstmoves the image's/etcto/usr/share/factory/etcand writes a tmpfilesCline for each entry.Ccopies only when the target is missing (tmpfiles.d(5)), and a disk install keeps/etcacross A/B updates. The element's own comment says what follows: "a copy would stay at the version the node first booted". resolved,system.confand the bash prompt were moved to/usrfor this reason. These three were not:/etc/ssh/sshd_config.d/bluefin-server.conf(os-sshd-config.bst,target: /etc/ssh)/etc/sysctl.d/10-console.confand/etc/systemd/journald.conf.d/10-console.conf, both written bybluefin-server-usr.bstThe sshd drop-in has already changed twice since the first FSDK release (v26.09.673): in 8824f9e, and to add
Subsystem sftpin b9033de. #700 changes it a third time. None of those changes reached a node installed before them.What changes
/usr/lib/sysctl.d/10-console.confand/usr/lib/systemd/journald.conf.d/10-console.conf. Both daemons read/usr/libdirectly, and an/etcfile with the same name still overrides it. The content is unchanged./usrconfig directory. The drop-in now lives in/usr/lib/bluefin/sshd_config.d/, andfiles/os/tmpfiles.d/50-bluefin-sshd.conflinks it in withL /etc/ssh/sshd_config.d/bluefin-server.conf. This is the same pattern as50-bluefin-prompt.conf.Lleaves an operator's own file alone. The mainsshd_config, which only includessshd_config.d/*.conf, stays in the factory/etc.os-sshd-config.bstbecomes a smallmanualelement that installs the two files to their two places, and the drop-in source moves tofiles/os/sshd_config.d/.bluefin-migrate-etc-vendor(a newbluefin-hosthelper,internal/host/etcvendor) cleans up existing installs:v2*tag (106 + 74 + 2 tags; three sshd versions, one each for the other two files), plus the version fix(ssh): accept a provisioned key while root is still locked #700 leaves./usr(sysinit.target.wants), like the other migrations. That way updated nodes run it too, which a preset would not do./var/lib/bluefin), on installed nodes only (diskless/etcstarts empty every boot), and is ordered beforesystemd-tmpfiles-setup.service, so the same boot links the new file in.docs/skills/ddi-installer.mdrecords the rule: a vendor setting that has to follow updates ships in/usr.Tests
tests/unit/test_etc_vendor_dropins.pychecks:/etc;bluefin-migrate-etc-vendorbinary removes unmodified copies, keeps an edited one, and writes the stamp.etcvendor_test.gocovers the same cases plus symlinks and missing files./etcgets the link;/etc/ssh(copy removed) gets the link;sshd -Tthrough the link reportsusepam yes,permitrootlogin prohibit-passwordandpasswordauthentication no.pytest -n auto: 1885 passed, 3 skipped.go vet ./...andgo test -race ./...(files/homelab/cluster): pass.docs-checks.py: clean.just validate: passes.full-buildrun, and ideally ane2e-opt-inrun, to prove it on a real update.🤖 Generated with Claude Code