Repository navigation
chore(deps): update oras-project/setup-oras action to v2.0.4 - #695
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. ℹ️ Sentinel: informational, author is trusted (allow-listed bot), merge is not blocked. Head
No Review follow-ups: 1 open of 1 (below
|
There was a problem hiding this comment.
Summary: This updates a small helper used by the release pipeline to install ORAS, a tool that uploads release files to a container registry, from version 2.0.3 to 2.0.4. The exact ORAS download and its fingerprint stay the same, so releases should behave as before. One difference: the helper now sends the workflow's built-in GitHub login when downloading from GitHub. That is safe here, but worth knowing about. Nothing blocks merging.
Pinned commit ac735097e22fe643015b0d19645f7c9a69942128 checked against upstream tag v2.0.4 (it matches). Both call sites keep the same url and checksum for ORAS 1.3.6 (.github/workflows/build.yml:727-730, :821-824). So the installed binary is the same.
CI at this head: every build/release job shows skipped (only prow ran). The new action version has not run in this repo yet. The risk is low because its inputs did not change.
docs-currency (out-of-scope, was already there before this PR): the comments at .github/workflows/build.yml:723 and :818 say "setup-oras v2.0.1's built-in release table stops at ORAS 1.3.3". At v2.0.4 the table includes 1.3.6 and 1.4.0 (upstream src/lib/data/releases.json), so the comment is out of date. Suggested fix on main:
# Pin the release the Justfile's oras_image names, by URL and checksum,
# rather than following setup-oras's built-in default version.No findings from: correctness, intent-alignment, style.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326
| # the release the Justfile's oras_image names, by URL and checksum. | ||
| - name: Set up oras | ||
| uses: oras-project/setup-oras@5e2f2482b30b0cb3e14e67f89a80c88c659a7c63 # v2.0.3 | ||
| uses: oras-project/setup-oras@ac735097e22fe643015b0d19645f7c9a69942128 # v2.0.4 |
There was a problem hiding this comment.
FYI (security, info): v2.0.4 adds a token input that defaults to github.token (upstream action.yml). src/setup.ts sends it as auth only when the download host is github.com, and masks it with core.setSecret. This job runs on pull requests (it checks out the PR head at :801-805), but the token is read-only for fork PRs and goes only to github.com. No change needed. If you want the download to send no login at all, add token: '' under with:. The same applies to the release job at line 727.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
This PR contains the following updates:
v2.0.3→v2.0.4Release Notes
oras-project/setup-oras
v2.0.4Compare Source
Highlights
What's Changed
New Contributors
Full Changelog: oras-project/setup-oras@v2.0.3...v2.0.4
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.