Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Justfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export oras_image := env("ORAS_IMAGE", "ghcr.io/oras-project/oras:v1.3.6@sha256:
# Same bst2 container image FSDK/dakota CI uses. Its tag names the
# freedesktop-sdk-docker-images commit it was built from; it is a mutable tag,
# not a digest pin.
export bst2_image := env("BST2_IMAGE", "registry.gitlab.com/freedesktop-sdk/infrastructure/freedesktop-sdk-docker-images/bst2:6f164dcf4368b8ed6f7ce91c854153335165b41b")
export bst2_image := env("BST2_IMAGE", "registry.gitlab.com/freedesktop-sdk/infrastructure/freedesktop-sdk-docker-images/bst2:8df3c33e7ef5b50c581596dfff1538c3168d47d0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness: tag bst2:8df3c33e7ef5b50c581596dfff1538c3168d47d0 is not published. I checked on 2026-11-18:

  • The registry returns 404 for the manifest at registry.gitlab.com/v2/freedesktop-sdk/infrastructure/freedesktop-sdk-docker-images/bst2/manifests/8df3c33e…. The current tag 6f164dcf… returns 200.
  • Upstream commit 8df3c33e (merged 2026-11-18 14:33 UTC) has master pipeline 3084575480 with status failed.

This is the case the PR body warns about: "A master commit whose image pipeline failed … has no tag." After merge, every just bst … call fails at the pull guard (Justfile:49-51, ERROR: could not pull bst2 image), unless BST2_IMAGE is overridden.

Fix: do not merge this head. Close it so Renovate proposes the next master commit, or wait for a passing re-run that publishes the tag. Before merging any later bump, confirm the tag exists with skopeo inspect. No base-branch change is needed: the hold rule (tests/unit/test_ci_workflows.py:182) worked as designed.

# bats for `just test-unit` when none is installed -- pinned by digest.
export bats_image := env("BATS_IMAGE", "docker.io/bats/bats:1.14.0@sha256:5322b877351fda0cc435de8c6116de7d0a2ec79d7c680132a0ef329a633bc66f")
# butane (built from the Ignition tree) for `just homelab-templates` -- pinned by digest.
Expand Down
Loading