Skip to content

fix(os-release): advertise the freedesktop-sdk base via ID_LIKE - #686

Open
cheese wants to merge 4 commits into
projectbluefin:mainfrom
cheese:os-release-id-like
Open

cheese wants to merge 4 commits into
projectbluefin:mainfrom
cheese:os-release-id-like

Conversation

@cheese

@cheese cheese commented Nov 17, 2026

Copy link
Copy Markdown

Bluefin Server is built on freedesktop-sdk, but its os-release does not advertise that base. Declare ID_LIKE="org.freedesktop.platform" so tools can detect the FSDK base without spoofing NAME/ID.

Assisted-by: DeepSeek V4.1 Flash via DeepSeek Harness

Bluefin Server is built on freedesktop-sdk, but its os-release does not
advertise that base. Declare ID_LIKE="org.freedesktop.platform" so tools
can detect the FSDK base without spoofing NAME/ID.

Signed-off-by: Robin Lee <robinlee.sysu@gmail.com>
Assisted-by: DeepSeek V4.1 Flash via DeepSeek Harness
@jeefy
jeefy requested review from castrojo and daegalus November 17, 2026 08:11
@jeefy

jeefy commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/untrusted Author has no registry profile or verified hive claim (or is revoked); never auto-merged stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 17, 2026
@cheese

cheese commented Nov 17, 2026

Copy link
Copy Markdown
Author

/assign @ahmedadan

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/stalled In its current stage longer than expected and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 17, 2026
@jeefy

jeefy commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ahmedadan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmedadan in a comment when ready.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/stalled In its current stage longer than expected labels Nov 17, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

stage 080-awaiting-merge-admission → 060-reviewed: contributor-lane:author-association

Ready for a human merge: verdict approved e52fe17, 18/18 checks green, soak 30m0s elapsed. Blocked only by role/untrusted (no verified hive claim or registry tier).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/stalled In its current stage longer than expected and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 17, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at ef6d801. It is a one-line addition to the os-release that the image writes, and I could not find a problem.

  • elements/bluefin-server/os-release.bst:27 adds ID_LIKE="org.freedesktop.platform". That value is the real ID= of Freedesktop SDK (the 25.08 runtime's /usr/lib/os-release reads ID=org.freedesktop.platform), so it names the actual base.
  • It is valid per os-release(5). ID_LIKE is a space-separated list of IDs, and an ID may contain lowercase letters, digits, ., _ and -. One entry with dots is fine, and the quotes are allowed.
  • It does not change ID=bluefin-server, so the sysext extension-release.* files that match ID=bluefin-server and the IMAGE_ID / IMAGE_VERSION handling are untouched.
  • Nothing in this repo reads ID_LIKE. The Go helpers (bootdeadline, sysextfetch, sys.ImageVersion) read only IMAGE_VERSION.

Two small notes, neither a blocker. The PR description has no linked issue, and I could not find one, so the motivation is only the PR body. A reader may also want to know the ordering rule: ID_LIKE lists the closest relative first, and there is only one here.

@hivecommons-hive hivecommons-hive Bot added stage/stalled In its current stage longer than expected and removed stage/stalled In its current stage longer than expected labels Nov 17, 2026
@jeefy jeefy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2026
@jeefy

jeefy commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added stage/stalled In its current stage longer than expected and removed stage/stalled In its current stage longer than expected labels Nov 18, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving on the current head. The change is still the single ID_LIKE="org.freedesktop.platform" line in os-release.bst, and checks pass.

@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge: GitHub Actions is holding workflow runs 44398377747, 44395539438, 44379936348, 44378444921, 44374347685, 44371976634, 44344688387, 44340570056, 44339900504, 44338547014, 44333272651, 44333208482, 44261912124, 44257752419, 44257016991, 44256755822, 44256755796, 44256755955, 44256755856 on this head for a maintainer's approval, and the hive's approval policy does not approve them on its own (an untrusted or fork head, or auto-approval is off). Until a maintainer reviews the change and clicks Approve and run in the PR's checks banner, no required check can report.

Head: verdict approved @e52fe17, 3/3 checks green, required not reported: actionlint, boot-test-preflight, boot-test-result, build, changes, docs, go (files/homelab/cluster), image-check, release-dry-run, unit, validate, zizmor, soak 29m0s of 30m0s.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

Updated 2026-11-18 21:20 UTC.

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/stalled In its current stage longer than expected and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/stalled In its current stage longer than expected labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/human A person pushed this PR themselves dco All commits are DCO signed-off role/untrusted Author has no registry profile or verified hive claim (or is revoked); never auto-merged stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants