Repository navigation
Conversation
Bluefin Server is built on freedesktop-sdk, but its os-release does not advertise that base. Declare ID_LIKE="org.freedesktop.platform" so tools can detect the FSDK base without spoofing NAME/ID. Signed-off-by: Robin Lee <robinlee.sysu@gmail.com> Assisted-by: DeepSeek V4.1 Flash via DeepSeek Harness
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @ahmedadan |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. stage 080-awaiting-merge-admission → 060-reviewed: contributor-lane:author-association Ready for a human merge: verdict approved The hive never approves on your behalf: |
Danathar
left a comment
There was a problem hiding this comment.
Approving at ef6d801. It is a one-line addition to the os-release that the image writes, and I could not find a problem.
elements/bluefin-server/os-release.bst:27addsID_LIKE="org.freedesktop.platform". That value is the realID=of Freedesktop SDK (the 25.08 runtime's/usr/lib/os-releasereadsID=org.freedesktop.platform), so it names the actual base.- It is valid per os-release(5).
ID_LIKEis a space-separated list of IDs, and an ID may contain lowercase letters, digits,.,_and-. One entry with dots is fine, and the quotes are allowed. - It does not change
ID=bluefin-server, so the sysextextension-release.*files that matchID=bluefin-serverand theIMAGE_ID/IMAGE_VERSIONhandling are untouched. - Nothing in this repo reads
ID_LIKE. The Go helpers (bootdeadline,sysextfetch,sys.ImageVersion) read onlyIMAGE_VERSION.
Two small notes, neither a blocker. The PR description has no linked issue, and I could not find one, so the motivation is only the PR body. A reader may also want to know the ordering rule: ID_LIKE lists the closest relative first, and there is only one here.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Danathar
left a comment
There was a problem hiding this comment.
Re-approving on the current head. The change is still the single ID_LIKE="org.freedesktop.platform" line in os-release.bst, and checks pass.
|
Needs a decision, not a merge: GitHub Actions is holding workflow runs 44398377747, 44395539438, 44379936348, 44378444921, 44374347685, 44371976634, 44344688387, 44340570056, 44339900504, 44338547014, 44333272651, 44333208482, 44261912124, 44257752419, 44257016991, 44256755822, 44256755796, 44256755955, 44256755856 on this head for a maintainer's approval, and the hive's approval policy does not approve them on its own (an untrusted or fork head, or auto-approval is off). Until a maintainer reviews the change and clicks Approve and run in the PR's checks banner, no required check can report. Head: verdict approved @e52fe17, 3/3 checks green, required not reported: actionlint, boot-test-preflight, boot-test-result, build, changes, docs, go (files/homelab/cluster), image-check, release-dry-run, unit, validate, zizmor, soak 29m0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-18 21:20 UTC. |
Bluefin Server is built on freedesktop-sdk, but its os-release does not advertise that base. Declare ID_LIKE="org.freedesktop.platform" so tools can detect the FSDK base without spoofing NAME/ID.
Assisted-by: DeepSeek V4.1 Flash via DeepSeek Harness