Skip to content

ci: name the exact install-action tag its pin points to - #667

Closed
Danathar wants to merge 1 commit into
mainfrom
fix/install-action-pin-comments
Closed

Danathar wants to merge 1 commit into
mainfrom
fix/install-action-pin-comments

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary: "Lint workflows" (zizmor) fails on every server pull request, including merge-queue runs for #591 and #639, because seven taiki-e/install-action pins carry a # v2 comment while the moving v2 tag points elsewhere. This changes only those comments, to # v2.90.2, the tag the pinned commit actually is. What runs is unchanged.

Details

  • Pin: taiki-e/install-action@3a3daafd3b7f23b8f65d9f5ba2db203fb59b79e2, which is tag v2.90.2. v2 now points to 4a76afe2.
  • Lines: build.yml 142, 182, 222 and 297; unit-tests.yml:45; track-junctions.yml:45; reproducibility.yml:64.
  • Proof: zizmor 1.32.0, the version lint-actions.yml runs, reports 7 ref-version-mismatch findings on main and "No findings to report" with this change.

Unblocks the lint check on #644, among others.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn

zizmor's ref-version-mismatch audit fails "Lint workflows" on every pull
request: taiki-e/install-action is pinned to 3a3daafd (tag v2.90.2) but
commented "# v2", and the moving v2 tag no longer points there. The pinned
commit is unchanged; only the seven comments now say v2.90.2. zizmor 1.32.0
(the version lint-actions.yml runs) reports no findings after this.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@jeefy
jeefy requested review from ahmedadan and daegalus November 14, 2026 13:52
@jeefy jeefy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2026
@jeefy

jeefy commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 14, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
61b314c

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @Danathar, head 61b314cbd039) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 4 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/build.yml
    • .github/workflows/reproducibility.yml
    • .github/workflows/track-junctions.yml
    • .github/workflows/unit-tests.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@Danathar

Copy link
Copy Markdown
Contributor Author

Stand-in review at 61b314c: good to merge. Verified taiki-e/install-action tag v2.90.2 is 3a3daafd3b7f23b8f65d9f5ba2db203fb59b79e2, the pinned commit, while v2 now points to 4a76afe2. So the comment change matches zizmor's ref-version-mismatch, and what runs is unchanged. No # v2 install-action pins remain in .github/workflows at this head. (Not an approval: this is Doug's PR.)

@hivecommons-hive

Copy link
Copy Markdown
Contributor

🐝 Possible duplicate

This PR changes exactly the same files as #640, which was opened first:

Evidence — identical changed-file set (4 file(s)):

  • .github/workflows/build.yml
  • .github/workflows/reproducibility.yml
  • .github/workflows/track-junctions.yml
  • .github/workflows/unit-tests.yml

This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides.

It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting.

@castrojo

Copy link
Copy Markdown
Contributor

/lgtm

@jeefy jeefy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2026
@jeefy
jeefy added this pull request to the merge queue Nov 14, 2026
@castrojo

Copy link
Copy Markdown
Contributor

/hold

Holding until the BuildStream cache root-cause fix #664 lands. Do not enqueue pre-fix builds.

@jeefy jeefy added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2026
@jeefy
jeefy removed this pull request from the merge queue due to a manual request Nov 14, 2026
@Danathar
Danathar added this pull request to the merge queue Nov 14, 2026
@castrojo

Copy link
Copy Markdown
Contributor

Superseded by #664: all seven exact install-action version-comment corrections are already committed in f96222b and online zizmor is green there. A second full queue build for this identical change is redundant. Closing rather than allowing automation to re-enqueue it; #664 must land first.

@castrojo castrojo closed this Nov 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a manual request Nov 14, 2026
@Danathar

Copy link
Copy Markdown
Contributor Author

Sorry, I re-queued this at 11:47 AM EST without seeing your /hold. Agreed it's superseded by #664.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants