Skip to content

fix(cache): seed brew-nspawn to CAS and prioritize Bluefin remote - #665

Closed
castrojo wants to merge 1 commit into
mainfrom
feat/cache-seeding-expansion
Closed

castrojo wants to merge 1 commit into
mainfrom
feat/cache-seeding-expansion

Conversation

@castrojo

@castrojo castrojo commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem

  1. While freedesktop-sdk.bst:components/linux.bst and components/go.bst are pushed to cache.projectbluefin.io:11002 by scripts/kernel-cache.sh, the Homebrew machine image (fsdk-containers.bst:oci/brew-nspawn.bst) and its dependency tree (brew-deps.bst, brew-runtime.bst) were not seeded. When cold runners build homebrew/image.bst, the brew container layers are missing from the CAS.
  2. In project.conf, https://gbm.gnome.org:11003 was listed before https://cache.projectbluefin.io:11001, forcing round-trip misses against GNOME CAS on all Bluefin-specific artifacts and custom kernels before falling back to the project cache.

Solution

  1. Add fsdk-containers.bst:oci/brew-nspawn.bst to ELEMENTS in scripts/kernel-cache.sh (verified key-free: does not reach bluefin-server/keys/boot-keys.bst).
  2. Prioritize https://cache.projectbluefin.io:11001 as the first remote in project.conf for both artifacts and source-caches.
  3. Update unit tests in tests/unit/test_kernel_cache.py to verify the expanded ELEMENTS list and skip behavior.

Critical Sequencing Note

PR #664 MUST merge before this PR.
build waits on kernel-cache. If #665 were to land before #664, the release seeder would compile brew-nspawn.bst against the un-collapsed duplicate FSDK graph (359 elements from scratch), causing multi-hour delays and producing cache keys that #664 immediately obsoletes. Once #664 is on main, #665 seeds brew-nspawn.bst against the host SDK where base elements are already warm.

Verification

  • just validate passes (799 subtasks resolved).
  • pytest tests/unit/test_kernel_cache.py tests/unit/test_ci_workflows.py passed (45/45).

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 14, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). The change itself looks fine. It depends on #664's decision, so I'm commenting rather than approving.

  • Remote order: putting cache.projectbluefin.io:11001 before gbm.gnome.org:11003 for both artifacts and source-caches is a clean win on its own. Bluefin-specific artifacts stop paying a GNOME miss first.
  • Seeding fsdk-containers.bst:oci/brew-nspawn.bst in kernel-cache.sh: this is only cheap with #664's junction collapse. Without it, brew-nspawn resolves through fsdk-containers.bst:freedesktop-sdk.bst:…, the separate uncached FSDK graph from #650, so the seed step in build.yml (kernel-cache.sh seed release / dev) would try to build that whole graph and could hit the same time limit. So it should land with #664 or after it, and #664 still needs @jeefy's call on the FSDK version skew. If #664 is changed to keep separate junctions, drop the seeding part and keep the remote reorder.
  • The unit-test update matches the new ELEMENTS, and the failing zizmor is #651 (pin comments), not this change.

@jeefy
jeefy requested review from ahmedadan and bketelsen November 14, 2026 01:45
@jeefy jeefy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2026
@jeefy

jeefy commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 14, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

@castrojo this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • zizmor

The same checks have failed on 2 heads so far (latest fcb78295f755).

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (5 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 14, 2026
@jeefy

jeefy commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add fsdk-containers.bst:oci/brew-nspawn.bst to ELEMENTS in
scripts/kernel-cache.sh so release and dev seeders push the key-free
brew machine and its dependency tree to cache.projectbluefin.io:11002.
Reorder artifacts and source-caches in project.conf to query the
project CAS remote first before upstream mirrors.

Assisted-by: GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: castrojo <castrojo@users.noreply.github.com>
@castrojo
castrojo force-pushed the feat/cache-seeding-expansion branch from 2381f7a to fcb7829 Compare November 14, 2026 01:58
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act dco All commits are DCO signed-off stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head no-dco A commit is missing Signed-off-by — run `git rebase --signoff` stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 14, 2026
@jeefy

jeefy commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 14, 2026
@castrojo

Copy link
Copy Markdown
Contributor Author

/hold

Consolidating this cache-seeding fix into #664 so the shared SDK graph, cache population, and required action-pin correction land together, before dependencies. No separate full build needed for this branch.

@jeefy jeefy added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2026
@castrojo

Copy link
Copy Markdown
Contributor Author

Superseded by #664 commit f96222b, which includes this Brew cache-seeding target, project-cache lookup ordering, and updated regression coverage. Keeping one complete fix and one queue build instead of a second cache-fix chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off hold Indicates that a PR should not merge because someone has issued a /hold command. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants