Repository navigation
test(join): wait for the source slot between rate-limit attempts - #406
Merged
Merged
Conversation
TestRateLimitPerSource joined three times in a row from one source. The server frees the source's slot after the client already has its answer, so the next attempt could be refused as busy ("attempt 1: control plane refused: busy"). It failed main's push builds 37264198746 and 37282526257 and both full builds of #404, inside homelab/bluefin-cluster.bst's go test. Wait for the slot like the replay tests do (#391).
Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeefy
added a commit
that referenced
this pull request
Oct 5, 2026
Assisted-by: Claude Opus 5.5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRateLimitPerSourcejoins three times in a row from one source. The server frees that source's slot only after the client already has its answer, so the next attempt can be refused asbusy(join_test.go:398: attempt 1: control plane refused: busy (retry after 1s)).This flake failed main's push builds 37264198746 and 37282526257, and both full builds of #404, because the test runs in
homelab/bluefin-cluster.bst'sgo test.The fix waits for the slot with
waitSlotFree, the same way the replay tests do since #391/#392. It changes the test only. Locally,go test -race -count=200andGOMAXPROCS=1 -count=500pass, andgo vetis clean.