Skip to content

test(join): wait for the source slot between rate-limit attempts - #406

Merged
jeefy merged 1 commit into
mainfrom
fix/ratelimit-test-slot-wait
Oct 5, 2026
Merged

jeefy merged 1 commit into
mainfrom
fix/ratelimit-test-slot-wait

Conversation

@jeefy

@jeefy jeefy commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

TestRateLimitPerSource joins three times in a row from one source. The server frees that source's slot only after the client already has its answer, so the next attempt can be refused as busy (join_test.go:398: attempt 1: control plane refused: busy (retry after 1s)).

This flake failed main's push builds 37264198746 and 37282526257, and both full builds of #404, because the test runs in homelab/bluefin-cluster.bst's go test.

The fix waits for the slot with waitSlotFree, the same way the replay tests do since #391/#392. It changes the test only. Locally, go test -race -count=200 and GOMAXPROCS=1 -count=500 pass, and go vet is clean.

TestRateLimitPerSource joined three times in a row from one source. The server frees the source's slot after the client already has its answer, so the next attempt could be refused as busy ("attempt 1: control plane refused: busy"). It failed main's push builds 37264198746 and 37282526257 and both full builds of #404, inside homelab/bluefin-cluster.bst's go test. Wait for the slot like the replay tests do (#391).

Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jeefy
jeefy merged commit 2c7b401 into main Oct 5, 2026
13 checks passed
jeefy added a commit that referenced this pull request Oct 5, 2026
Assisted-by: Claude Opus 5.5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant