Skip to content

[scanner] fix: add PXE netboot installer support - #25

Closed
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-pxe
Closed

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-pxe

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Fix\n\nAdds standalone PXE kernel/initrd artifacts, opt-in HTTP(S) DDI fetching with checksum verification, explicit target-disk selection, and PXE documentation. Existing embedded-DDI installs remain unchanged.\n\nRefs #14\n\nNote: release workflow asset-copy wiring is not included because GitHub App lacks workflows permission; workflow change is ready to apply once permission is granted.\n\n---\nFiled by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=scanner backend=copilot model=gpt-5.6-luna

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2026

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @castrojo for Hive auto-merge on green CI.

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation itself is sound and was previously approved by a human maintainer with CI green at the time — but mergeable_state is now dirty: main has since independently merged the PXE-artifact-export portion (kernel/initrd + SHA256SUMS lines) that this PR also adds, so it now textually conflicts. Needs a rebase before it can land. See also #22/#26/#27 in this same repo — four overlapping PXE PRs that need reconciling; details in the review on #27.


Generated by Claude Code

@castrojo

castrojo commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Superseded by merged PR #23 which published standalone PXE boot artifacts.

@castrojo castrojo closed this Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants