Repository navigation
chore(deps): update projectbluefin/actions digest to b0fbcf6 - #172
mergeraptor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
hanthor
left a comment
There was a problem hiding this comment.
The digest bump itself is a genuine no-op, and I want to state that first because it makes the rest of this sharper.
6680f74..b0fbcf6 is exactly one commit, b0fbcf6 "fix(promotion): gate queue enrollment on verification (#513)", touching three paths:
.github/workflows/reusable-promote-squash.yml
docs/skills/factory-operations.md
tests/test_promote_gate_order.py
build.yml:179 pins server-installer-test.yml, which is byte-identical across the range (git diff --shortstat 6680f74 b0fbcf6 -- .github/workflows/server-installer-test.yml → empty). Nothing in that bump reaches this repo.
But this PR is not only a digest bump, and its title says it is.
Two of the three changed files are BuildStream junctions:
elements/freedesktop-sdk.bst 26.08.0-0-gdb97cce → 26.08.1-0-gb02b59f
elements/gnome-build-meta.bst 50.4-0-g8524013 → 50.4-5-gd78f498
That is a freedesktop-sdk point release and five commits of gnome-build-meta — the entire base of the OS — arriving inside a PR whose title, body and Renovate table describe a GitHub Actions ref change. They came from the second commit on the branch, ed0d7bf "chore: resolve BuildStream junction refs to git-describe format", pushed by github-actions[bot] 49 seconds after Renovate opened the PR.
That commit is build.yml's track-refs job:
if: github.event_name == 'pull_request' && startsWith(github.head_ref, 'renovate/')
...
just bst source track freedesktop-sdk.bst || true
just bst source track gnome-build-meta.bst || true
if ! git diff --exit-code; then ... git push origin "HEAD:${HEAD_REF}"; fi
The message says "resolve to git-describe format", but both refs were already in git-describe format. What actually happens is that bst source track re-resolves the track: globs — freedesktop-sdk-26.08* and gnome-50 — against their remotes and takes whatever is newest. So the job does not normalise a format; it performs an unpinned upstream bump, on every renovate/* PR, whatever that PR was about.
Three consequences, and the combination is why I'm requesting changes rather than commenting:
- The label on the tin is wrong. Anyone reviewing "chore(deps): update projectbluefin/actions digest to b0fbcf6" is not reviewing an SDK point release, and the Renovate body gives them no reason to look.
- It carries the
automergelabel and Renovate reports "Automerge: Enabled". So the path exists for an FSDK bump to reachmainwith no human having read it. - It routes around the automerge policy the org just tightened.
projectbluefin/actions6e4587bgates Renovate automerge to no-new-code update types (pin/pinDigest) specifically so that automerge can't introduce new code. That gate inspects what Renovate proposed. Here the new code is injected afterwards, by CI, into a PR that already passed the gate. The check is being evaluated against a commit that is no longer the head.
What I'd suggest, in rough order of how much I'd want it:
- Have
track-refsopen its own PR for junction movement instead of pushing into whateverrenovate/*branch happens to be open. That keeps "the SDK moved" a reviewable event with its own title. - Failing that, make it refuse to push when the resolved ref crosses a version boundary rather than merely a commit, and strip
automergefrom any PR it has pushed to. - Independently:
|| trueon bothbst source tracklines means a tracking failure is indistinguishable from "nothing to do". If tracking silently fails, the job reports success and the build proceeds on the old ref. Worth at least logging the outcome.
Also worth a second look, though I'm less sure of it: track-refs grants contents: write and then checks out github.event.pull_request.head.repo.full_name and runs that tree's Justfile. The renovate/* branch-name gate is the only guard, and a branch name is not an identity — a fork PR can be branched renovate/anything. GitHub does force GITHUB_TOKEN read-only for pull_request events from forks, which should make the git push fail rather than succeed, so I don't think this is currently exploitable. I'd still rather the gate checked github.event.pull_request.user.login or head.repo.full_name == github.repository than the branch name, since the workflow's own comment treats the branch gate as the security boundary.
For completeness: mergeable_state: unstable, head ed0d7bf, no commit statuses posted.
Generated by Claude Code
|
Following up on my review with something more useful than a complaint: dakota already solves this, and server is the only repo in the org doing it the other way. I grepped every repo's workflows for
So the fix here doesn't need designing, just porting: move the two Worth noting dakota's tracker also carries a comment at Still requesting changes on the PR as it stands, for the reasons in the review. Generated by Claude Code |
|
Closing. The advertised change is a verified no-op for this repository, so what remains is an unlabelled OS-base bump sitting behind an The advertised payload delivers nothing here. What the PR actually contains besides that. Two BuildStream junction bumps that appear in no title, body, or Renovate table:
That is an FSDK point release and five commits of gnome-build-meta — effectively the base of the OS — inside a PR labelled as an Actions digest update. Merging it as-is would turn Why I am not just deleting the two hunks. They are not authored by Renovate. The real fix is the one @hanthor proposed — move junction tracking to a scheduled workflow that opens its own PR on its own branch, as No content is lost by closing: the pinned workflow file is unchanged across the range, so the current pin is functionally identical. If Renovate treats this closure as "ignore this update" rather than re-raising, the pin can be refreshed deliberately once Filing the |
This PR contains the following updates:
6680f74→b0fbcf6Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.