Repository navigation
Description
Summary: The developer commands that copy the optional add-ons (ZFS, NVIDIA, Tailscale, NetBird and others) out of a local build are written out by hand, one near-identical copy per add-on. The copies have already drifted once (a ZFS copy step that never matched its file, #306), and today the Kubernetes (k0s) command deletes whatever the other commands already exported. Folding the copies into one shared step, checked by a test, stops each new add-on from bringing its own variant.
Architecture Finding
Type: tech-debt / duplication with drift
Affected area: Justfile (export-*sysext recipes), tests/unit/test_sysext_export_contract.py
Every opt-in sysext export recipe repeats the same 7-line body (checkout into a scratch dir, copy <prefix>*.raw.zst to dist/sysext/, append its SHA256SUMS line, remove scratch, list). There are five byte-for-byte copies differing only in name and prefix — export-zfs-sysext, export-nvidia-sysext, export-nvidia-container-toolkit-sysext, export-tailscale-sysext, export-netbird-sysext — plus a loop variant (export-homelab-sysext) and a divergent one (export-sysext, k0s). NetBird (#555) added the latest copy.
Drift already present:
export-sysext(k0s) runsrm -rf dist/sysextand overwritesdist/sysext/SHA256SUMSwithcp; every other recipemkdir -pand appends. Sojust export-zfs-sysext export-sysextleaves only k0s indist/sysext/— the result depends on call order.- The glob contract test (
test_export_recipes_copy_globs_match_the_element_image_names) pins only zfs and nvidia-open-595. The tailscale, netbird and nvidia-container-toolkit globs are unchecked, which is exactly how Review backlog (correctness): export-zfs-sysext cp glob never matches the zfs artifact #306 (zfs glob never matched) shipped. - The appending recipes add a duplicate
SHA256SUMSline on every re-run.
Impact
Each new opt-in sysext copies one of the existing bodies, choosing whichever variant it starts from; the test has to be extended by hand for each one or the new glob is unguarded.
Recommendation
- One private recipe
_export-sysext-element NAME PREFIXholds the body; the five single-element recipes call it (pure refactor, no behaviour change), and a unit test checks every caller'sPREFIXagainst the element'ssysext-imageand fails if a newexport-*-sysextrecipe re-inlines the body instead of calling the helper. -
export-sysext(k0s) stops wipingdist/sysext/and appends itsSHA256SUMSline like the others, then calls the same helper; the helper drops a stale line for the same file before appending so re-runs do not duplicate. This changes what the command does, so it is left to the fix lane rather than the refactor PR.
Decision taken by hive: the refactor PR covers the first box only; the k0s ordering and duplicate-line fix are behaviour changes and stay open here for a fix PR.
Filed by architect agent (ACMM L6 — full mode)
— hive: agent=architect backend=copilot model=claude-opus-5.5 copilot=1.0.88
Activity
jeefy commentedon Nov 7, 2026
Issue triage
Next action: a triager or maintainer reviews this issue.
Reporter or contributor
kind/*label is set, categorize the issue with one of:/kind bug,/kind regression,/kind security,/kind feature,/kind documentationor/kind cleanup./area <area>:desktop,flatpak,gaming,hardware,installerordx.Triager or maintainer
/triage accepted. Only triagers and maintainers can do this; acceptance does not assign an implementer.needs-kindclears when a kind is set.needs-triageand this post clear when triage is accepted.See Triage & Prow Commands for all available commands.
jeefy commentedon Nov 7, 2026
Issue triage
Next action: a triager or maintainer reviews this issue.
Reporter or contributor
kind/*label is set, categorize the issue with one of:/kind bug,/kind regression,/kind security,/kind feature,/kind documentationor/kind cleanup./area <area>:desktop,flatpak,gaming,hardware,installerordx.Triager or maintainer
/triage accepted. Only triagers and maintainers can do this; acceptance does not assign an implementer.needs-kindclears when a kind is set.needs-triageand this post clear when triage is accepted.See Triage & Prow Commands for all available commands.
jeefy commentedon Nov 7, 2026
Issue triage
Next action: a triager or maintainer reviews this issue.
Reporter or contributor
kind/*label is set, categorize the issue with one of:/kind bug,/kind regression,/kind security,/kind feature,/kind documentationor/kind cleanup./area <area>:desktop,flatpak,gaming,hardware,installerordx.Triager or maintainer
/triage accepted. Only triagers and maintainers can do this; acceptance does not assign an implementer.needs-kindclears when a kind is set.needs-triageand this post clear when triage is accepted.See Triage & Prow Commands for all available commands.
5 remaining items
hivecommons-hive commentedon Nov 9, 2026
🌱 Good first issue — bring your own coding agent
Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-projectbluefin-knuckle-gjvq picked this issue as a good place to start because:
How to land it (no waiting on a human):
git commit -s).Fixes #638— that closing keyword is how hive's contributor lane links the PR to your claim.Paste this to your agent
Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-projectbluefin-common-nmq5.hive.hivecommons.dev/contribute.
If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.
test: check the homelab export through the shared export step
Refactor the five single-element export-*-sysext recipes onto one hel…
fix: exporting one add-on no longer deletes the add-ons exported befo…