Skip to content

[ci-maintainer] just is installed unpinned (just@latest) in build.yml, kernel.yml and unit-tests.yml while every action is SHA-pinned #188

Closed

Description

@hivecommons-hive

CI Issue

Every GitHub Action in this repository is pinned to a full commit SHA — actions/checkout@3d3c42e5…, actions/upload-artifact@043fb46d…, taiki-e/install-action@7b8d4719…, even the reusable projectbluefin/actions/.github/workflows/server-installer-test.yml@6680f74b…. The one build tool that is not pinned is just, which drives every job in the repo:

  • .github/workflows/build.yml:42 — tool: just
  • .github/workflows/build.yml:80 — tool: just
  • .github/workflows/kernel.yml:42 — tool: just
  • .github/workflows/unit-tests.yml:44 — tool: just

With no version specifier, taiki-e/install-action resolves just@latest at run time. CI therefore executes a just binary whose version is decided by an upstream release, not by anything in this repository.

That matters here because just is not incidental tooling — it is the build: just validate, just test-unit, just test-installer-artifact and the DDI/kernel export recipes carry the repository's entire CI contract. A just release that changes recipe parsing, [group]/attribute handling, shell invocation, or exit-code propagation turns every job red (or, worse, silently green) with no commit in this repo to bisect against, and the same commit that builds today can fail tomorrow.

Evidence

  • Run 35379640734 (Build DDI artifacts, PR chore(deps): update projectbluefin/actions digest to 8895d09, and freedesktop-sdk to 26.08.1 + gnome-build-meta to 50.4-5 #183), build job, tool install step:
    info: installing just@latest
    info: downloading https://github.com/casey/just/releases/download/1.58.0/just-1.58.0-x86_64-unknown-linux-musl.tar.gz
    info: verifying sha256 checksum for just-1.58.0-x86_64-unknown-linux-musl.tar.gz
    info: just installed at /home/runner/.cargo/bin/just
    + just --version
    just 1.58.0
    
    install-action verifies the checksum of whatever it chose to download; it does not constrain which version that is.
  • grep -rn "tool: just" .github/workflows/ returns exactly the four unversioned call sites listed above.
  • Nothing else in the repository declares a just version: grep -rn "just@" Justfile .pre-commit-config.yaml docs/ returns nothing.

Disjoint from the open installer-test / Install and boot in QEMU incident (#175, #161, #158, #166) — that is a boot-time /var discovery failure inside the VM, not a tooling-version problem — and disjoint from #187, which changes only the on: block of unit-tests.yml.

Recommendation

Pin the tool to the version CI already resolves today, so applying this changes no behavior. In .github/workflows/build.yml (lines 42 and 80), .github/workflows/kernel.yml (line 42) and .github/workflows/unit-tests.yml (line 44), replace each occurrence of:

        with:
          tool: just

with:

        with:
          tool: just@1.58.0

Four occurrences, no other change. Bumping it afterwards is then a reviewable one-line commit, and Renovate's github-actions manager can track it like any other pinned dependency.

Verification after applying

# 1. no unversioned call site remains
grep -rn "tool: just$" .github/workflows/          # -> no output
grep -rc "tool: just@1.58.0" .github/workflows/*.yml
# build.yml -> 2, kernel.yml -> 1, unit-tests.yml -> 1

# 2. the pinned version still runs the suite
just --version    # just 1.58.0
just test-unit

# 3. on the next PR, the install step logs
#    "info: installing just@1.58.0" instead of "just@latest"

Who can land this

This change cannot be pushed by this agent. All four call sites live under .github/workflows/**, and this agent's GitHub App token is minted at the contributor tier, which does not carry the Workflows permission; GitHub rejects such a push server-side regardless of what the App installation grants. It needs a maintainer using their own user credentials, or an ISSUES_PRS_MERGE agent on an installation that has accepted Workflows read/write. That is a hard tier ceiling, not a judgement call. No part of this fix lives outside .github/workflows/, so there is no companion PR.


Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode)

— hive: agent=ci-maintainer backend=copilot model=claude-opus-5 copilot=1.0.78

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/ci-maintainerFiled or owned by the ci-maintainer agent.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions