Repository navigation
Revert "feat: Bluefin bootc-ISO builder (bootcDirect + containers-storage, 8 GB)" #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| --- | ||
| name: Build All ISOs | ||
| # Orchestrator workflow that calls ALL individual ISO build workflows | ||
| # Builds ALL production ISOs with production tags only | ||
| # | ||
| # For testing tags (-testing), use the dedicated testing workflow: | ||
| # - build-iso-lts-hwe-testing.yml (the ONLY authorized workflow for testing tags) | ||
| # | ||
| # Total: 8 production ISOs across all variants: | ||
| # - build-iso-stable → 2 Stable ISOs (amd64 × main, amd64 × nvidia-open) | ||
| # - build-iso-lts → 4 LTS ISOs (amd64/arm64 × main, amd64/arm64 × gdx) | ||
| # - build-iso-lts-hwe → 2 LTS-HWE ISOs (amd64/arm64 × main) | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| upload_artifacts: | ||
| description: 'Upload ISOs as job artifacts' | ||
| type: boolean | ||
| default: false | ||
| upload_r2: | ||
| description: 'Upload ISOs to Cloudflare R2' | ||
| type: boolean | ||
| default: true | ||
| schedule: | ||
| - cron: "0 3 1 * *" # Push to testing bucket on the first of the month at 03:00 UTC - 2h after Bluefin publishes monthly builds. | ||
|
|
||
| jobs: | ||
| build-iso-lts: | ||
| name: Build LTS ISOs | ||
| uses: ./.github/workflows/reusable-build-iso-anaconda.yml | ||
| secrets: inherit | ||
| with: | ||
| image_version: lts # Strictly LTS only | ||
| image_tag: lts # Hardcoded: build-iso-all.yml only builds production tags | ||
| upload_artifacts: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_artifacts || false }} | ||
| upload_r2: ${{ github.event_name != 'workflow_dispatch' || inputs.upload_r2 }} | ||
|
|
||
| build-iso-lts-hwe: | ||
| name: Build LTS-HWE ISOs | ||
| uses: ./.github/workflows/reusable-build-iso-anaconda.yml | ||
| secrets: inherit | ||
| with: | ||
| image_version: lts-hwe # Strictly LTS-HWE only | ||
| image_tag: lts-hwe | ||
| upload_artifacts: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_artifacts || false }} | ||
| upload_r2: ${{ github.event_name != 'workflow_dispatch' || inputs.upload_r2 }} | ||
|
|
||
| build-iso-stable: | ||
| name: Build Stable ISOs | ||
| uses: ./.github/workflows/reusable-build-iso-anaconda.yml | ||
| secrets: inherit | ||
| with: | ||
| image_version: stable # Strictly Stable only | ||
| image_tag: stable | ||
| upload_artifacts: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_artifacts || false }} | ||
| upload_r2: ${{ github.event_name != 'workflow_dispatch' || inputs.upload_r2 }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| name: Build LTS-HWE Testing ISOs | ||
| # This is the ONLY authorized workflow for building lts-hwe-testing ISOs. | ||
| # Testing tags (lts-hwe-testing) must NOT be used in build-iso-lts-hwe.yml or | ||
| # build-iso-all.yml — those workflows are for production tags only. | ||
| # Note: choice-input removal enforces this at the UI/CLI level; direct API | ||
| # callers must follow this policy by convention. | ||
| # Builds: 2 LTS-HWE testing ISOs | ||
| # - amd64 x main | ||
| # - arm64 x main | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| upload_artifacts: | ||
| description: 'Upload ISOs as job artifacts' | ||
| type: boolean | ||
| default: false | ||
| upload_r2: | ||
| description: 'Upload ISOs to Cloudflare R2' | ||
| type: boolean | ||
| default: true | ||
| schedule: | ||
| - cron: '17 6 * * 1' # Every Monday at 06:17 UTC | ||
|
|
||
| jobs: | ||
| build-iso-lts-hwe-testing: | ||
| name: Build LTS-HWE Testing ISOs | ||
| uses: ./.github/workflows/reusable-build-iso-anaconda.yml | ||
| secrets: inherit | ||
| with: | ||
| image_version: lts-hwe | ||
| image_tag: lts-hwe-testing | ||
| upload_artifacts: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_artifacts || false }} | ||
| upload_r2: ${{ github.event_name != 'workflow_dispatch' || inputs.upload_r2 }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --- | ||
| name: Build LTS-HWE ISOs | ||
| # This workflow ONLY builds LTS-HWE ISOs (not GTS, Stable, or LTS) | ||
| # Builds: 2 LTS-HWE ISOs | ||
| # - amd64 × main | ||
| # - arm64 × main | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| image_tag: | ||
| description: 'Image tag to build from (production only; for lts-hwe-testing use build-iso-lts-hwe-testing.yml)' | ||
| type: choice | ||
| options: | ||
| - lts-hwe | ||
| default: lts-hwe | ||
| upload_artifacts: | ||
| description: 'Upload ISOs as job artifacts' | ||
| type: boolean | ||
| default: false | ||
| upload_r2: | ||
| description: 'Upload ISOs to Cloudflare R2' | ||
| type: boolean | ||
| default: true | ||
| schedule: | ||
| - cron: '0 2 1 * *' # 2am UTC on the 1st of every month | ||
|
|
||
| jobs: | ||
| build-iso-lts-hwe: | ||
| name: Build LTS-HWE ISOs | ||
| uses: ./.github/workflows/reusable-build-iso-anaconda.yml | ||
| secrets: inherit | ||
| with: | ||
| image_version: lts-hwe # Strictly builds LTS-HWE ISOs only | ||
| image_tag: ${{ github.event_name == 'workflow_dispatch' && inputs.image_tag || 'lts-hwe' }} | ||
| upload_artifacts: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_artifacts || false }} | ||
| upload_r2: ${{ github.event_name != 'workflow_dispatch' || inputs.upload_r2 }} |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,38 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||||||||||||||||||||||||
| name: Build LTS ISOs | ||||||||||||||||||||||||||||||||||||||||||||||||||
| # This workflow ONLY builds LTS ISOs (not GTS, Stable, or LTS-HWE) | ||||||||||||||||||||||||||||||||||||||||||||||||||
| # Builds: 4 LTS ISOs | ||||||||||||||||||||||||||||||||||||||||||||||||||
| # - amd64 × main | ||||||||||||||||||||||||||||||||||||||||||||||||||
| # - amd64 × gdx | ||||||||||||||||||||||||||||||||||||||||||||||||||
| # - arm64 × main | ||||||||||||||||||||||||||||||||||||||||||||||||||
| # - arm64 × gdx | ||||||||||||||||||||||||||||||||||||||||||||||||||
| on: | ||||||||||||||||||||||||||||||||||||||||||||||||||
| workflow_dispatch: | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add required warning comments about LTS breakage. The guideline states: "Do NOT remove or alter the inline warning comments in
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| --- | |
| name: Build LTS ISOs | |
| # This workflow ONLY builds LTS ISOs (not GTS, Stable, or LTS-HWE) | |
| # Builds: 4 LTS ISOs | |
| # - amd64 × main | |
| # - amd64 × gdx | |
| # - arm64 × main | |
| # - arm64 × gdx | |
| on: | |
| workflow_dispatch: | |
| --- | |
| name: Build LTS ISOs | |
| # ⚠️ CRITICAL WARNING: LTS ISOs ARE CURRENTLY BROKEN ⚠️ | |
| # The Anaconda installer is broken for LTS variants. Do not re-enable the | |
| # schedule or promote any LTS builds to production until the breakage is resolved. | |
| # Safe testing: Run manually with upload_r2: false to test fixes without uploading. | |
| # This workflow ONLY builds LTS ISOs (not GTS, Stable, or LTS-HWE) | |
| # Builds: 4 LTS ISOs | |
| # - amd64 × main | |
| # - amd64 × gdx | |
| # - arm64 × main | |
| # - arm64 × gdx | |
| on: | |
| workflow_dispatch: |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/build-iso-lts.yml around lines 1 - 10, The workflow file
`build-iso-lts.yml` is missing required warning comments about LTS breakage
status in the header section. Add the warning comment block to the workflow
header that appears after the name field and before the existing comments about
what ISOs are built. The warning should inform users about the LTS breakage
status according to your project's guidelines for this workflow file, ensuring
the inline warning comments are properly included and not removed or altered.
Source: Coding guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schedule must be disabled — LTS ISOs are broken.
The guideline explicitly states: "Do NOT re-enable the build-iso-lts.yml schedule — LTS ISOs are currently broken and the schedule must remain commented out to prevent automatic execution."
🚫 Proposed fix: comment out the schedule and add warning
+ # ⚠️ CRITICAL WARNING: LTS ISOs ARE CURRENTLY BROKEN ⚠️
+ # Do NOT uncomment the schedule below until:
+ # 1. The Anaconda breakage is resolved
+ # 2. Test builds succeed end-to-end with upload_r2: false
+ # 3. ISOs are manually inspected before any production promotion
+ # Building LTS ISOs with upload_r2: false (artifacts only) is safe for testing.
+ #
- schedule:
- - cron: '0 2 1 * *' # 2am UTC on the 1st of every month
+ # schedule:
+ # - cron: '0 2 1 * *' # 2am UTC on the 1st of every month📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| schedule: | |
| - cron: '0 2 1 * *' # 2am UTC on the 1st of every month | |
| # ⚠️ CRITICAL WARNING: LTS ISOs ARE CURRENTLY BROKEN ⚠️ | |
| # Do NOT uncomment the schedule below until: | |
| # 1. The Anaconda breakage is resolved | |
| # 2. Test builds succeed end-to-end with upload_r2: false | |
| # 3. ISOs are manually inspected before any production promotion | |
| # Building LTS ISOs with upload_r2: false (artifacts only) is safe for testing. | |
| # | |
| # schedule: | |
| # - cron: '0 2 1 * *' # 2am UTC on the 1st of every month |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/build-iso-lts.yml around lines 26 - 27, The schedule block
containing the cron expression at lines 26-27 must be commented out to prevent
automatic execution of the build-iso-lts workflow, as LTS ISOs are currently
broken and non-functional. Comment out the entire schedule section (the lines
starting with "schedule:" and the cron expression) and add a comment explaining
that the schedule is disabled due to LTS ISO issues being broken, to ensure
future developers understand why the automation is intentionally disabled.
Source: Coding guidelines
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| name: Build Stable ISOs | ||
| # This workflow ONLY builds Stable ISOs (not LTS, LTS-HWE, or GTS) | ||
| # Builds: 2 Stable ISOs | ||
| # - amd64 × main | ||
| # - amd64 × nvidia-open | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| upload_artifacts: | ||
| description: 'Upload ISOs as job artifacts' | ||
| type: boolean | ||
| default: false | ||
| upload_r2: | ||
| description: 'Upload ISOs to Cloudflare R2' | ||
| type: boolean | ||
| default: true | ||
| schedule: | ||
| - cron: '0 2 1 * *' # 2am UTC on the 1st of every month | ||
|
|
||
| jobs: | ||
| build-iso-stable: | ||
| name: Build Stable ISOs | ||
| uses: ./.github/workflows/reusable-build-iso-anaconda.yml | ||
| secrets: inherit | ||
| with: | ||
| image_version: stable # Strictly builds Stable ISOs only | ||
| image_tag: stable | ||
| upload_artifacts: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_artifacts || false }} | ||
| upload_r2: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_r2 || true }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix The current expression
The user input is completely ignored. This differs from the correct pattern used in all other workflows. 🔧 Proposed fix: align with other workflows- upload_r2: ${{ github.event_name == 'workflow_dispatch' && inputs.upload_r2 || true }}
+ upload_r2: ${{ github.event_name != 'workflow_dispatch' || inputs.upload_r2 }}This matches the pattern in
🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schedule must be disabled — LTS builds are broken.
The guideline explicitly states: "Do NOT trigger
build-iso-all.ymlexpecting it to promote LTS to production — the LTS builds are currently broken." The enabled schedule will automatically trigger broken LTS builds on the first of each month.🚫 Proposed fix: comment out the schedule
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines