Repository navigation
chore: remove logo hacks - #54
Conversation
Fedora 44 ships the ananconda version with the fix merged so we can get rid of this nastiness See: rhinstaller/anaconda-webui@fe65289 See: https://bugzilla.redhat.com/show_bug.cgi?id=2433186
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe script no longer performs RPM database manipulation for logo packages. Two code blocks that downloaded fedora-logos and registered them via ChangesLogo RPM Manipulation Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
hanthor
left a comment
There was a problem hiding this comment.
The 'Build ISOs' CI check is failing. Even though the change is a cleanup removal, the build needs to pass before merge. Please investigate the ISO build failure and fix it.
The failure has absolutely nothing to do with my change. |
hanthor
left a comment
There was a problem hiding this comment.
LGTM. Clean removal of the logo hack workaround.
Verified:
- Removes the
generic-logos→fedora-logoshack (Bugzilla #2433186 workaround) - Removes the post-install
fedora-logoserase - No other logic changes — Anaconda config and profile detection unchanged
- Lines removed are all within the logo-hack block, no collateral damage
hanthor
left a comment
There was a problem hiding this comment.
Clean removal of logo hacks. LGTM.
hanthor
left a comment
There was a problem hiding this comment.
LGTM. Clean removal of the generic-logos → fedora-logos swap hack. Fedora 44 ships the upstream Anaconda fix so this workaround is no longer needed. The script is now simpler and the remaining logo configuration is unaffected.
hanthor
left a comment
There was a problem hiding this comment.
Approved: Removes stale logo hacks — rpm erase/download workaround for an old bugzilla. Clean removal, no risk.
Fedora 44 ships the ananconda version with the fix merged so we can get rid of this nastiness
See: rhinstaller/anaconda-webui@fe65289
See: https://bugzilla.redhat.com/show_bug.cgi?id=2433186
Summary by CodeRabbit