Skip to content

chore: remove logo hacks - #54

Merged
hanthor merged 1 commit into
mainfrom
remove-logo-hack
May 30, 2026
Merged

hanthor merged 1 commit into
mainfrom
remove-logo-hack

Conversation

@renner0e

@renner0e renner0e commented May 11, 2026 •

Copy link
Copy Markdown
Contributor

Fedora 44 ships the ananconda version with the fix merged so we can get rid of this nastiness

See: rhinstaller/anaconda-webui@fe65289
See: https://bugzilla.redhat.com/show_bug.cgi?id=2433186

Summary by CodeRabbit

  • Chores
    • Removed unnecessary RPM package manipulation operations from ISO configuration setup. The legacy code block performing intermediate logo package registration steps has been eliminated, while all core system configuration, profile generation, key enrollment, and package installation processes remain unchanged.

Review Change Stack

Fedora 44 ships the ananconda version with the fix merged so we can get
rid of this nastiness

See: rhinstaller/anaconda-webui@fe65289
See: https://bugzilla.redhat.com/show_bug.cgi?id=2433186
@dosubot dosubot Bot added the size:XS label May 11, 2026
@coderabbitai

coderabbitai Bot commented May 11, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 64d3c5e4-1552-4c0a-a3a1-e164fd4b713c

📥 Commits

Reviewing files that changed from the base of the PR and between 07d158c and 1c9ba7f.

📒 Files selected for processing (1)
  • iso_files/configure_iso_anaconda.sh
💤 Files with no reviewable changes (1)
  • iso_files/configure_iso_anaconda.sh

📝 Walkthrough

Walkthrough

The script no longer performs RPM database manipulation for logo packages. Two code blocks that downloaded fedora-logos and registered them via rpm --justdb, then erased them, have been removed. All other Anaconda configuration and package installation logic remains unchanged.

Changes

Logo RPM Manipulation Removal

Layer / File(s) Summary
Remove Logo RPM Hack Block
iso_files/configure_iso_anaconda.sh
Removed the HACK block (lines 53–55) that manipulated generic-logos and fedora-logos RPM database entries, and removed the subsequent standalone rpm --erase command (line 68) that removed fedora-logos.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 No more logo tricks and HACK blocks wild,
The RPM dance is reconciled,
Generic and fedora fade away,
The ISO stands cleaner today! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove logo hacks' directly and concisely describes the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-logo-hack

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added lgtm labels May 11, 2026

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Build ISOs' CI check is failing. Even though the change is a cleanup removal, the build needs to pass before merge. Please investigate the ISO build failure and fix it.

@dosubot dosubot Bot removed the lgtm label May 29, 2026
@renner0e

Copy link
Copy Markdown
Contributor Author

The 'Build ISOs' CI check is failing. Even though the change is a cleanup removal, the build needs to pass before merge. Please investigate the ISO build failure and fix it.

The failure has absolutely nothing to do with my change.

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean removal of the logo hack workaround.

Verified:

  • Removes the generic-logos → fedora-logos hack (Bugzilla #2433186 workaround)
  • Removes the post-install fedora-logos erase
  • No other logic changes — Anaconda config and profile detection unchanged
  • Lines removed are all within the logo-hack block, no collateral damage

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal of logo hacks. LGTM.

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean removal of the generic-logos → fedora-logos swap hack. Fedora 44 ships the upstream Anaconda fix so this workaround is no longer needed. The script is now simpler and the remaining logo configuration is unaffected.

@dosubot dosubot Bot added the lgtm label May 29, 2026

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Removes stale logo hacks — rpm erase/download workaround for an old bugzilla. Clean removal, no risk.

@hanthor
hanthor merged commit 1dbf75f into main May 30, 2026
20 of 23 checks passed
@castrojo castrojo added 4-review A pull request is awaiting review. and removed area/iso labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4-review A pull request is awaiting review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants