Repository navigation
refactor: remove the unused release-feed widget (FeedItems.tsx) and its orphan modules - #1567
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
FeedItems.tsx has no importer, and its @theme/useStoredFeed provider no longer exists; only the ambient shim in src/types/theme.d.ts let it type check. Remove it together with the modules reachable only from it (FeedItems.module.css, utils/sbomRelease.ts, config/packageConfig.ts, lib/sbom-feed-adapter.ts, lib/sbom-adapter.ts) and the shim, and point the SBOM cache-key comments at the live consumer, sbomKeyForRelease() in utils/firehoseHelpers.ts. Closes #1566 Signed-off-by: architect <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "architect" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This deletes about 2,000 lines of website code for an old release-feed widget that no page shows any more. Nothing on the site changes for visitors. It only removes code that looked live and kept getting edited by mistake.
What I need from you: Review and lift the hold if you agree.
Refactor
Removes the files that an import-graph walk over the repo finds unreachable from any page, theme override, doc, blog post, config or script:
src/components/FeedItems.tsx(no importer)src/components/FeedItems.module.css,src/utils/sbomRelease.ts(imported only by FeedItems.tsx)src/config/packageConfig.ts(no importer)src/lib/sbom-feed-adapter.ts(no importer) andsrc/lib/sbom-adapter.ts(imported only by sbom-feed-adapter.ts)src/types/theme.d.ts: the ambient declaration for@theme/useStoredFeed. Nothing provides that module any more, so this shim was the only reason FeedItems.tsx type-checked.It also repoints three stale references from FeedItems to the live consumer of the SBOM cache-key format,
sbomKeyForRelease()insrc/utils/firehoseHelpers.ts(used byFirehoseFeed.tsx): comments insrc/types/sbom.tsandscripts/lib/sbom/parser.js, and one test name inscripts/sbom-parser.test.js. The SBOM cache data and its fetch pipeline are unchanged, becauseFirehoseFeed.tsxandImageProductSection.tsxstill read them.Verification
npx tsc --noEmit: same 6 errors asorigin/main, allCannot find module '@site/static/data/*.json'for generated data thatfetch-dataproduces. No new errors.npx eslint src scripts: 0 errors.node --test "scripts/**/*.test.js": 1306 pass, 0 fail.grepforFeedItems.tsx|sbomRelease|sbom-feed-adapter|packageConfig|useStoredFeedoversrc/,scripts/,docs/: no remaining references.Closes #1566
Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=architect backend=copilot model=claude-opus-5.5 copilot=1.0.88