Repository navigation
Conversation
Use a stable user symlink to the installed Bluefin Extra images and a narrow read-only Flatpak grant. Preserve existing profiles and avoid image bundling, copying, conversion, or app changes. Assisted-by: GPT-6.1-SOL via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: castrojo The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
Decision needed (@projectbluefin): this PR appears to duplicate #1186, which already merged: every file it touches was also changed there (the sweep compares file names, not contents). Recommended: close as superseded. Other options: keep open, or merge anyway. This comment is edited in place by the supersession sweep; it is not duplicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bluefin-common PR
What does this change?
Configure Damask's Slideshow default to use the user's existing Homebrew Bluefin Extra artwork through a stable per-user folder pointer.
bluefin-wallpapers-extracask's existing flatimagesdirectory.~/.local/share/backgrounds/bluefin-extraat that directory with one symlink, refreshed before the first-run settings gate so package upgrades do not leave a versioned path in app settings.active-source='none'.No artwork downloads, copying, conversion, Containerfile changes, app fork, extra named provider, package-list changes, or existing-profile migration. This does not repair the separate outdated Lazy Days release asset.
Why?
Refs #1161.
Damask reads immediate image files from one directory. The cask's user-published wallpaper folders are nested, so the existing flat Homebrew image directory is the supported collection source. The previous default selected system wallpapers instead of the extra artwork.
Verification
bats tests/test_damask_setup.bats tests/test_damask_service.bats: 13 passed, onesystemd-analyzecheck skipped because the isolated Alpine environment lacks that binary.25-damask-setup.sh.python -m pytest -o addopts='' tests/test_skill_docs.py -q: 17 passed.just checkandpre-commit run --all-filespassed.How this PR merges
Prow requests two reviews from
OWNERS. A reviewer who is not the author comments/lgtm(removed on every push), anOWNERSapprover comments/approveor approves in GitHub, and Common also needs 2 approving GitHub reviews. With green checks, Prow puts the PR in the merge queue./holdpauses it. See how issues and PRs work here.Checklist
just checkpassespre-commit run --all-filespassesAI attribution
The commit includes:
CI results
Passed for
986b103: