Conversation
Danathar
marked this pull request as draft
September 19, 2026 01:19
Require human review for GitHub Actions minor and patch updates while preserving digest and pin automerge. Keep first-party actions behind the same review gate because the issue targets the github-actions manager and no approved exception exists. Closes #1074.\n\nAssisted-by: GPT-5.6-Luna via GitHub Copilot\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danathar
force-pushed
the
fix/1074-github-actions-review-gate
branch
from
September 19, 2026 01:23
62f070d to
9d18459
Compare
Danathar
marked this pull request as ready for review
September 19, 2026 01:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1074
Summary
github-actionsminor and patch updates.Effective behavior before
The inherited
projectbluefin/renovate-configrules automerged digest, pin, patch, and minor updates, including a GitHub Actions non-major grouping rule and a separateprojectbluefin/actionsautomerge rule.common/renovate.jsonthen enabled GitHub-native platform automerge for the same update types. The current open Renovate PR #1144 has the inheritedgithub-actions (non-major)group name and reportsAutomerge: Enabled, confirming that the inherited layer is active.Renovate's live config filename order is
renovate.json, then.github/renovate.json,.github/renovate.jsonc, and.github/renovate.json5; it stops at the first existing file. Therefore the rootrenovate.jsonis the active repository config. A live Renovate run on this repository reports managersdockerfile(1 file / 9 dependencies),github-actions(11 / 40), andrenovate-config; it reports nocustom.regexmanager. If.github/renovate.json5were active, itsenabledManagers: ["github-actions", "custom.regex"]would also disable the observeddockerfilemanager.This makes
.github/renovate.json5a real tracking gap, not just duplicate configuration: its twocustom.regexmanagers are inactive, so the wallpaperCOPY --from=digest andBONEDIGGER_VERSIONpins are not being tracked even thoughdocs/skills/ci-tooling/references/renovate-and-tools.mdsays they are. Its stale GitHub Actions automerge rule would also re-arm if the root file were removed or config selection changed.This PR intentionally leaves that separate configuration repair out of #1074. Open issue #1147 owns the concrete
commonfix. #433 was closed as completed after its custom-manager remediation was added to the inactive.github/renovate.json5; the wallpaper-digest part of that remediation therefore never took effect. #1147 explicitly supersedes that incomplete result and should determine whether #433 is reopened. The broader audit RFC #1103 records this as evidence for its organization-wide proposal, but does not replace the repository-specific repair.Rule interaction and fix
Renovate evaluates all matching
packageRulesentries in order; later entries override earlier values. The new rule is last incommon/renovate.json, matchesgithub-actionsplusminor/patch, and setsautomerge: false. It therefore overrides both inherited GitHub Actions automerge rules and the local broad automerge rule.The rule intentionally also gates
projectbluefin/actions. The issue targets thegithub-actionsmanager, and no approved policy exception exists for first-party actions. Digest and pin automation remains the safe content-addressed path.The inherited
github-actions (non-major)grouping remains intact. Renovate computes branch automerge as the logical AND of the grouped upgrades' automerge values, so a mixed digest plus minor/patch group waits for human review as a whole; digest-only groups continue to automerge.Result
Validation
npx --yes --package renovate@44.101.3 renovate-config-validator --strict --no-global renovate.jsonjust checkuv run --with pytest pytest tests/test_renovate_config.py -qPATH=/tmp/omp-precommit/bin:$PATH PYTHONPATH=/tmp/omp-precommit/lib/python3.14/site-packages uvx pre-commit run --all-filesgit diff --checkautomerge: false, digest/pin actions resolve toautomerge: true,projectbluefin/actionsminor resolves tofalse, and an npm minor remainstrue.