Skip to content

chore(triage): consolidate duplicate and superseded issues/PRs in the open backlog (2026-10-10) #1445

Closed as not planned

Description

@mrbobbytables

Scope

Backlog hygiene pass over all open issues (49) and PRs (19) in projectbluefin/common on 2026-10-10, looking for duplicates, superseded PRs, and items that should be consolidated. No changes were made; this issue collects the findings for maintainer action.

PRs that supersede or conflict with each other

Keep Close / fold in Evidence
#1434 #1413 #1434's body states it carries #1413's test commit (cherry-picked unchanged) plus the fix. Both touch tests/test_actions_security.py. #1434 also resolves #1411 and #1412.
#1392 #1267 #1392 contains both of #1267's commits plus the LUKS warning, and edits the same 5 files. #1392's body offers two paths (replace #1267, or cherry-pick 0f92948 into it). Pick one; whichever lands closes #1262 and #1391.
#1365 vs #1425 decision needed Mutually exclusive. #1365 removes the projectbluefin/chairlift packageRule and version pins from renovate.json/Containerfile; #1425 adds automerge to that same rule. Direction must be chosen before either merges.
#1430 + #1414 rebase order Both edit system_files/shared/usr/share/chairlift/config.yml. Not duplicates, but the second to land needs a rebase.

Issues obsoleted if #1365 (decouple ChairLift pins) lands

All four are Hive review-backlog findings about ChairLift version-stamp/pin drift. #1365 deletes the stamps and pins they complain about:

Recommend: decide #1365 first; if it merges, close these four as consolidated. If #1365 is rejected, they stay valid.

Duplicate / overlapping issues

Already correctly paired (no action)

#1370→#1371, #1137→#1196, #1431→#1433 are 1:1 issue→PR pairs and carry hive/covered-by-pr. #1410 and #1440 are both Renovate actions bumps but touch different actions; not duplicates.

Suggested order of operations

  1. Decide refactor(chairlift): decouple ChairLift version pins from common #1365 vs chore(deps): enable automerge for ChairLift release bumps #1425 (unblocks or closes four ChairLift drift issues).
  2. Decide feat(hibernation): warn before writing swapfile to non-LUKS /var #1392 vs feat(just): add opt-in hibernation setup #1267 path (closes Add ujust to enable/disable hibernation and suspend-then-hibernate while respecting Gnome power settings #1262, Review backlog (security): No warning that hibernation image lands unencrypted on non-LUKS disks #1391).
  3. Merge fix(actions-security): strip YAML quotes from uses: and catch flow-list pull_request_target #1434, close test(actions-security): cover allowed forms, warnings, exemptions and fallback parser #1413 (closes [quality] check-actions-security.py: no-PyYAML fallback misses flow-list pull_request_target; quoted uses: misparsed #1411, [quality] check-actions-security.py: allowed-form, warning/--strict, exemption and fallback-parser branches untested #1412).
  4. Close ci: promotion candidate E2E failed — 2026-10-06 #1407 as dup of [ci-maintainer] Promotion Candidate E2E red 4+ weeks: run-testsuite.yml pins testsuite 391 commits behind (missing testsuite#683 extension fix) #1427; consolidate add a ujust script to install docker #1298/Need documentation for how to install Docker stack on Dakota #1297; link Point Ask Bluefin at ChairLift's --ask-bluefin dispatcher (chairlift-wrapper --ask-bluefin); drop ask.projectbluefin.io #1396 under Ship Ask Bluefin desktop defaults for Agent Mode #1163.

Filed by GitHub Copilot CLI (Claude Fable 5.1) backlog review.

Activity

  1. added
    needs-kindA maintainer must classify this issue; the intake source did not establish its kind.
    on Oct 10, 2026
  2. mrbobbytables commented on Oct 10, 2026

    @mrbobbytables
    Author

    /kind cleanup

  3. added
    kind/cleanupTech debt, refactoring, tests or process.
    and removed
    needs-kindA maintainer must classify this issue; the intake source did not establish its kind.
    on Oct 10, 2026
  4. mrbobbytables commented on Oct 10, 2026

    @mrbobbytables
    Author

    Priority list — verified against live state 2026-10-10 (~19:00 UTC)

    Re-checked every PR/issue in the body. All are still open, but review state moved since filing: seven PRs now carry approved, none carry lgtm, and every one of them is mergeable_state: blocked except #1196 (clean). The gate they share is the Common two-review ruleset + /lgtm, not conflicts or red checks.

    P0 — mergeable now; needs only /lgtm and/or a second GitHub review

    # PR Latest reviews Blocker Closes
    1 #1196 record setup version only after hook succeeds Danathar ✅ castrojo ✅ hanthor ✅ · approved · clean /lgtm only #1137
    2 #1440 projectbluefin/actions digest bump Danathar ✅ · approved · sentinel-alert 2nd review + /lgtm; ack sentinel —
    3 #1410 github-actions non-major bumps Danathar ✅ · approved · sentinel-alert 2nd review + /lgtm; ack sentinel —
    4 #1434 actions-security quote/flow-list fix castrojo ✅ · approved 2nd review + /lgtm #1411, #1412 → then close #1413 (its test commit is carried in #1434; #1413 is on a Hive hold that would otherwise need a human to lift)
    5 #1430 Ask Bluefin → chairlift --ask-bluefin castrojo ✅ · approved 2nd review + /lgtm #1396
    6 #1414 ChairLift Help link targets Danathar ✅ 2nd review + /lgtm —

    #1430 and #1414 both edit system_files/shared/usr/share/chairlift/config.yml. Land #1430 first (it closes an issue), then rebase #1414.

    P1 — maintainer decision required before merge

    # Decision Recommendation Evidence
    7 #1392 vs #1267 (hibernation) Merge #1392, close #1267 as superseded. #1392: Danathar ✅ (latest), approved, rebased onto main today with check-skill-catalog fixed and 20/20 bats passing. #1267: zero reviews, sentinel-alert. #1392 carries both of #1267's commits unchanged, so @arteeh's authorship is preserved. Lands #1262 + #1391.
    8 #1365 vs #1425 (ChairLift pins) Direction = #1365; close #1425 as superseded. #1365: approved (castrojo), rebased today with a follow-up that validates against the cask's shipped release — i.e. it addresses the false-green concern Danathar raised. But Danathar's CHANGES_REQUESTED (2026-10-04) predates that push and still stands → needs a re-review. #1425: zero reviews, and it adds automerge to the exact packageRule #1365 deletes. On #1365 merge, close #1443, #1296, #1388, #1408 as consolidated.

    P2 — issue-only consolidation (no code; label/close actions)

    1. Close ci: promotion candidate E2E failed — 2026-10-06 #1407 as duplicate of [ci-maintainer] Promotion Candidate E2E red 4+ weeks: run-testsuite.yml pins testsuite 391 commits behind (missing testsuite#683 extension fix) #1427. ci: promotion candidate E2E failed — 2026-09-15 #1123, ci: promotion candidate E2E failed — 2026-09-22 #1169, ci: promotion candidate E2E failed — 2026-09-29 #1285 are already closed; ci: promotion candidate E2E failed — 2026-10-06 #1407 is the only live weekly symptom left. [ci-maintainer] Promotion Candidate E2E red 4+ weeks: run-testsuite.yml pins testsuite 391 commits behind (missing testsuite#683 extension fix) #1427 (the root cause: run-testsuite.yml 391 commits behind) has no open PR — it needs a triage/accepted + owner, otherwise next Tuesday files #14xx again.
    2. Remove System Update, Community, Documentation apps #1442 → Proposed rework of the icons used for the Community, Documentation and System Update desktop shortcuts #864. Remove System Update, Community, Documentation apps #1442 is parked awaiting /hive approve / /hive decision. Once a maintainer answers, close Proposed rework of the icons used for the Community, Documentation and System Update desktop shortcuts #864 (already blocked) if removal is the direction.
    3. add a ujust script to install docker #1298 + Need documentation for how to install Docker stack on Dakota #1297 (Docker on Dakota). Fold Need documentation for how to install Docker stack on Dakota #1297 (docs) into add a ujust script to install docker #1298 (ujust recipe), keep add a ujust script to install docker #1298. Search found no open PR that references either despite add a ujust script to install docker #1298's hive/covered-by-pr label — worth confirming the label is current.
    4. Point Ask Bluefin at ChairLift's --ask-bluefin dispatcher (chairlift-wrapper --ask-bluefin); drop ask.projectbluefin.io #1396 → child of Ship Ask Bluefin desktop defaults for Agent Mode #1163. Add the parent link so Ship Ask Bluefin desktop defaults for Agent Mode #1163 doesn't re-implement the dispatcher after fix: point Ask Bluefin at ChairLift --ask-bluefin dispatcher #1430 merges.
    5. bootc upgrade fails #1332 (hive/likely-done, upstream bootc/containers-storage) — ping reporter for /fixed; close if no reply. bootc-update-stage exits 1 on an up-to-date composefs system #1417 stays separate (composefs digest contract bug, on hold).

    P3 — stalled PRs that cover accepted issues

    1. test(gvariant): add regression coverage for menu tuple parser #1433 (covers Review backlog (style): GVariant tuple parser splits on bare commas #1431) — Danathar CHANGES_REQUESTED + test check failing. Needs author action before anything else.
    2. test(devmode): cover toggle-devmode's install path #1371 (covers [quality] toggle-devmode install path has no tests — only the decline branch is covered #1370) — Hive ACMM hold; approved-by-nobody. A human must lift the hold, then it enters the normal review path.
    3. test(actions-security): cover allowed forms, warnings, exemptions and fallback parser #1413 — do not review; close when fix(actions-security): strip YAML quotes from uses: and catch flow-list pull_request_target #1434 lands (see P0 docs: add AGENTS.md for Copilot onboarding #4).

    Suggested execution order

    1. /lgtm fix: record setup version only after the hook body succeeds #1196 → queue.
    2. Second reviews + /lgtm on chore(deps): update projectbluefin/actions digest to a52da56 #1440, chore(deps): update github-actions (non-major) #1410, fix(actions-security): strip YAML quotes from uses: and catch flow-list pull_request_target #1434, fix: point Ask Bluefin at ChairLift --ask-bluefin dispatcher #1430, fix(chairlift): point Help links at the pages their titles name #1414 (in that order; rebase fix(chairlift): point Help links at the pages their titles name #1414 after fix: point Ask Bluefin at ChairLift --ask-bluefin dispatcher #1430).
    3. Decide feat(hibernation): warn before writing swapfile to non-LUKS /var #1392/feat(just): add opt-in hibernation setup #1267 → merge feat(hibernation): warn before writing swapfile to non-LUKS /var #1392, close feat(just): add opt-in hibernation setup #1267, Add ujust to enable/disable hibernation and suspend-then-hibernate while respecting Gnome power settings #1262, Review backlog (security): No warning that hibernation image lands unencrypted on non-LUKS disks #1391.
    4. Re-review refactor(chairlift): decouple ChairLift version pins from common #1365 post-rebase; if accepted close chore(deps): enable automerge for ChairLift release bumps #1425, then Review backlog (correctness): ChairLift schema validator pin lags cask release #1443/Review backlog (docs-currency): GUI (cask) vs helper (image pin) version skew undocumented #1296/Review backlog (docs-currency): renovate.json rationale says ChairLift publishes prereleases only #1388/Review backlog (docs-currency): Vendored ChairLift asset attribution still cites v26.09.0-alpha.2 #1408.
    5. Close ci: promotion candidate E2E failed — 2026-10-06 #1407; accept + assign [ci-maintainer] Promotion Candidate E2E red 4+ weeks: run-testsuite.yml pins testsuite 391 commits behind (missing testsuite#683 extension fix) #1427; link Point Ask Bluefin at ChairLift's --ask-bluefin dispatcher (chairlift-wrapper --ask-bluefin); drop ask.projectbluefin.io #1396→Ship Ask Bluefin desktop defaults for Agent Mode #1163; fold Need documentation for how to install Docker stack on Dakota #1297→add a ujust script to install docker #1298; close test(actions-security): cover allowed forms, warnings, exemptions and fallback parser #1413.
    6. Unblock test(gvariant): add regression coverage for menu tuple parser #1433 (author) and test(devmode): cover toggle-devmode's install path #1371 (hold release) separately.

    Filed by GitHub Copilot CLI (Claude Fable 5.1) on behalf of @mrbobbytables.

  5. kylerankin commented on Oct 10, 2026

    @kylerankin
    Contributor

    🐝 Hive Agent: contributor | SHA: e3d4cbb

  6. added
    needs-decisionWaiting on a maintainer decision; not contributor work until a human clears the label
    on Oct 10, 2026
  7. hivecommons-hive commented on Oct 10, 2026

    @hivecommons-hive
    Contributor

    What to reply

    • /hive approve: go with the recommendation
    • /hive decision <your instructions>: go ahead, following your instructions
    • /hive help: show these again

    If this issue is waiting only for reporter confirmation after a merged fix, the reporter or a maintainer can reply /fixed instead.

    Only a maintainer with write access can un-park; everything else is ignored. Full command reference: https://github.com/hivecommons/hive/blob/v5/src/docs/maintainer-commands.md.

  8. self-assigned this
    on Oct 12, 2026
  9. added
    stage/085-needs-decisionA human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue
    stage/045-needs-decisionIssue parked on a person: needs-human or a maintainer decision is owed before the hive picks it up
    and removed
    needs-decisionWaiting on a maintainer decision; not contributor work until a human clears the label
    stage/085-needs-decisionA human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue
    on Oct 17, 2026
  10. Danathar commented on Oct 22, 2026

    @Danathar
    Contributor

    Closing as superseded by #1493, which carries this checklist forward. Most rows here are closed or merged, and the two whose premise inverted (#1392, #1365) are tracked there.

  11. removed
    stage/045-needs-decisionIssue parked on a person: needs-human or a maintainer decision is owed before the hive picks it up
    on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

kind/cleanupTech debt, refactoring, tests or process.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions