Skip to content

Review backlog (intent-alignment): #1229 premise (enabled via presets) does not hold in #1226 head #1294

Closed as not planned

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #1234.

PR: #1234
Perspective: intent-alignment
Evidence: system_files/shared/usr/lib/systemd/user/ffmpeg-thumbnailer-daemon.service:24
Severity: info

#1226 (d30d404) ships only [Install] WantedBy= with no preset and no static wants/ symlink, and nothing starts the container quadlets, so the thumbnailer is never on by default and this toggle's enable branch becomes the only enablement path. Belongs to #1226, not this PR.

Activity

  1. mendezr commented on Sep 29, 2026

    @mendezr
    Contributor

    The premise is stale rather than a code gap: PR #1226 at head d30d404 removes the user preset, static wants link, and WantedBy= from both quadlet container units. Its daemon unit retains WantedBy=graphical-session.target default.target, but without an enabling preset/link that does not auto-enable it. The related open PR #1234 is already framed as an opt-in ujust toggle. There is no standalone repository change for #1294; the remaining correction is to the original #1229 issue wording.

    — hive: backend=pi model=openrouter/openai/gpt-6-luna


    🐝 Hive Agent: contributor | SHA: unknown

  2. added
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    and removed
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Sep 29, 2026
  3. added
    needs-humanHuman input is required before Hive may start new implementation work.
    needs-kindA maintainer must classify this issue; the intake source did not establish its kind.
    on Oct 3, 2026
  4. hivecommons-hive commented on Oct 3, 2026

    @hivecommons-hive
    ContributorAuthor

    What to reply

    • /hive approve: go with the recommendation
    • /hive decision <your instructions>: go ahead, following your instructions
    • /hive help: show these again

    If this issue is waiting only for reporter confirmation after a merged fix, the reporter or a maintainer can reply /fixed instead.

    Only a maintainer with write access can un-park; everything else is ignored. Full command reference: https://github.com/hivecommons/hive/blob/v5/src/docs/maintainer-commands.md.

  5. added
    kind/bugSomething is broken.
    and removed
    needs-kindA maintainer must classify this issue; the intake source did not establish its kind.
    on Oct 3, 2026
  6. castrojo commented on Oct 4, 2026

    @castrojo
    Contributor

    This was generated by AI during triage.

    Triage outcome

    Obsolete, not shipped: Review backlog (intent-alignment): #1229 premise (enabled via presets) does not hold in #1226 head.

    Evidence:

    • PR #1226 and PR #1234 are CLOSED with no merge commit.
    • The finding addresses the enablement premise of those withdrawn changes, not a new report of shipped behavior.

    Close as not planned: the change being audited was withdrawn, not shipped. PRs #1226 and #1234 are both closed without merge; no preset claim from either is an active main-branch contract.

    No image delivery or implementation approval is inferred from this closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething is broken.needs-humanHuman input is required before Hive may start new implementation work.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions