Skip to content

ci: wire test_ffmpeg_thumbnailer.py into unit-tests.yml workflow #1228

Closed

Description

@castrojo

Description

PR #1226 added tests/test_ffmpeg_thumbnailer.py and registered it in the repo's Justfile (test: target).

Due to GitHub OAuth app workflow token permissions, changes touching .github/workflows/unit-tests.yml could not be pushed in the PR branch.

Proposed Fix

A maintainer with workflow scope should add the test execution step to .github/workflows/unit-tests.yml:

      - name: Run pytest (ffmpeg-thumbnailer)
        run: python3 -m pytest tests/test_ffmpeg_thumbnailer.py -v

This will ensure the thumbnailer test suite runs on every pull request and merge group.

Activity

  1. buggtb commented on Sep 25, 2026

    @buggtb
    Contributor

    Investigated: tests/test_ffmpeg_thumbnailer.py (and the corresponding unit-tests.yml step referenced in this issue) only exist on PR #1226 (feat/ffmpeg-thumbnailer), which is still open and unmerged (mergeStateStatus: BLOCKED, reviewDecision: REVIEW_REQUIRED, maintainerCanModify: false, authored by a maintainer so I cannot push to that branch).

    The test file does not exist on main yet, so wiring a pytest step referencing tests/test_ffmpeg_thumbnailer.py into .github/workflows/unit-tests.yml on main right now would break CI (the file wouldn't be found). The correct fix is for PR #1226 to be reviewed/merged with the workflow step included (or for a maintainer with workflow scope to push the one-line step to that PR's branch as the issue proposes), after which this issue is resolved as part of that merge.

    This is gated on a maintainer decision (review/merge of #1226, or granting workflow-scope push access to that branch) rather than something I can action from a fork.

    — hive: backend=pi model=pi-claude-code-provider/sonnet

    🐝 Hive Agent: contributor | SHA: 3399e47

  2. added
    needs-decisionWaiting on a maintainer decision; not contributor work until a human clears the label
    on Sep 25, 2026
  3. hivecommons-hive commented on Oct 1, 2026

    @hivecommons-hive
    Contributor

    What to reply

    • /hive approve: go with the recommendation
    • /hive decision <your instructions>: go ahead, following your instructions
    • /hive help: show these again

    If this issue is waiting only for reporter confirmation after a merged fix, the reporter or a maintainer can reply /fixed instead.

    Only a maintainer with write access can un-park; everything else is ignored. Full command reference: https://github.com/hivecommons/hive/blob/v5/src/docs/maintainer-commands.md.

  4. added
    needs-humanHuman input is required before Hive may start new implementation work.
    needs-kindA maintainer must classify this issue; the intake source did not establish its kind.
    and removed on Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-decisionWaiting on a maintainer decision; not contributor work until a human clears the labelneeds-humanHuman input is required before Hive may start new implementation work.needs-kindA maintainer must classify this issue; the intake source did not establish its kind.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions