fix(setup-runner): support ubuntu-26.04 runners and skip resolute apt source (#541) - #549
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
🐝 Possible duplicateThis PR changes exactly the same files as #542, which was opened first:
Evidence — identical changed-file set (5 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
There was a problem hiding this comment.
style
- (low)
tests/bats/test_setup_runner.bats:19-56—PODMAN_SOURCE_LOGICis labeled "Verbatim from bootc-build/setup-runner/action.yml" (and the file header says "Keep these snippets verbatim"), but it already drifts from the action at merge time: the test snippet has an extra comment line# before skipping the apt source.thataction.yml:77does not. The new drift guard (test_setup_runner.bats:391-398) only greps a few structural lines, so it won't catch this or future divergence. Suggest syncing the comment and/or tightening the guard.
No findings from: correctness, security, intent-alignment, docs-currency.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
What does this change?
Fixes #541.
On
ubuntu-26.04(andubuntu-26.04-arm) runners,bootc-build/setup-runnerfailed immediately duringSelect podman source(formerlyAdd Ubuntu resolute apt source) because oftest "${IDV}" = "ubuntu-24.04"underset -e, blocking every consumer's Renovate runner bump (e.g. projectbluefin/dakota#1592, projectbluefin/bluefin#1307, projectbluefin/common#1142).This PR:
case "${IDV}"block.ubuntu-24.04, configures the resolute apt source and sets outputinstall-from-resolute=true.ubuntu-26.04, verifiespodman --versionmajor >= 5 at runtime, emits an informational notice, and sets outputinstall-from-resolute=false, safely skipping the apt repository and upgrade.install-from-resolute == 'true'.docs/skills/composite-actions/action-reference.md,docs/skills/composite-actions.md, anddocs/skills/testing.md.tests/bats/test_setup_runner.batswith unit tests for all branches and adds a drift guard verifying action.yml structure.Consumer validation
Consumer PR: projectbluefin/bluefin#1307
Consumer CI run: TODO
Out-of-org consumer impact: N/A — backward compatible with existing ubuntu-24.04 runners while unblocking ubuntu-26.04.
ublue-os/aurora,ublue-os/bazzite) and documented the impact aboveChecklist
feat:,fix:,chore:, etc.)