Fix flaky TestTamperedTokenFails (qryptinvite) reddening main CI#18
Merged
Conversation
flipLastChar toggled only the last base64 char of the signature segment. For a 64-byte Ed25519 signature that char carries unused trailing bits, so the toggle could decode back to the same bytes and still verify — making the "corrupted signature must fail" assertion flaky (it reddened main CI). Corrupt a decoded signature byte (sig[0] ^= 0xFF) and re-encode instead, so the signature always differs. Verified deterministic over 50 runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flipLastChartoggled only the last base64 char of the signature segment; for a 64-byte Ed25519 signature that char holds unused trailing bits, so the toggle could decode back to the same bytes and still verify — making the assertion flaky and turningmain'stestworkflow red. Now corrupts a decoded signature byte (sig[0] ^= 0xFF) instead. Verified deterministic over 50 runs;go vetclean.🤖 Generated with Claude Code