remove hiredis require#1
Open
bkmaibach wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DON'T MERGE OR DELETE THIS BRANCH UNTIL READING BELOW!!
See:
redis/redis-rb#1178
This line is removed to allow installation of the Redis 7 gem which no longer allows "require 'redis/connection/hiredis'"
We can remove this because from here because we were not using hiredis anyway (we were forcing usage of the driver: :ruby directive)
For now, we will leave a reference to this remove_hiredis branch on the main productmotion gemfile - we should go back to using the main repo once the main repo supports the Redis 7 gem.