Stop suppressing every workflow on the version commit - #1878
Merged
Conversation
The version commit that versioned_source pushes carried a GitHub skip-ci directive. GitHub applies those repository-wide rather than per-workflow, so it also silenced downstream pipelines that key deployments off pushes to the default branch (balena-os). Replace the directive with a Flowzone-version-commit trailer and veto the re-entrant run inside Flowzone instead, so only Flowzone skips. Every job lists event_types in its needs, directly or transitively, which makes that job's if: the single point able to veto a whole run. Two independent signals, because either can be absent: the app's sender login covers any push the app makes, and the trailer covers the legacy FLOWZONE_TOKEN path where the pusher is a human account. The veto is required rather than a cost saving. balena_publish, website_publish and custom_always gate only on `trusted`, which is true for any push, so a self-triggered run would push a second balena release and redeploy the Cloudflare Pages site. Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
kyle/version-commit-no-skip-ci
branch
from
August 10, 2026 13:09
186d1d9 to
433a19c
Compare
Contributor
|
Website deployed to CF Pages, 👀 preview link https://581d6552.flowzone.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version commit that versioned_source pushes carried [skip ci]. GitHub applies skip directives repository-wide rather than per-workflow, so it also silenced downstream pipelines that key deployments off pushes to the default branch (balena-os).
Replace the directive with a Flowzone-version-commit trailer and veto the re-entrant run inside Flowzone instead, so only Flowzone skips. Every job lists event_types in its needs, directly or transitively, which makes that job's if: the single point able to veto a whole run. Two independent signals, because either can be absent: the app's sender login covers any push the app makes, and the trailer covers the legacy FLOWZONE_TOKEN path where the pusher is a human account.
The veto is required rather than a cost saving. balena_publish, website_publish and custom_always gate only on
trusted, which is true for any push, so a self-triggered run would push a second balena release and redeploy the Cloudflare Pages site.Change-type: patch