Add Chinese translation for organizing-code-with-functions.mdx#1302
Add Chinese translation for organizing-code-with-functions.mdx#1302Chiuye wants to merge 5 commits intoprocessing:mainfrom
Conversation
|
@lirenjie95 Hi, sorry I'm a newcomer contributing to an open-source GitHub project for the first time, so I might not be familiar with some aspects. 😥😣 |
lirenjie95
left a comment
There was a problem hiding this comment.
Hi @Chiuye, thanks for your contribution! The translation looks great overall. I've noted a few places that read a bit awkward for your reference.
Regarding the issue attached to this PR — it's required for the main p5.js repo, though I didn't see it as a strict requirement for p5.js-website. Let's leave it as is. Feel free to tag the maintainer for merging once I've approved your new changes.
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
src/content/tutorials/zh-Hans/organizing-code-with-functions.mdx
Outdated
Show resolved
Hide resolved
|
Hi @Chiuye and welcome! In general, we do prefer that there's an issue before a PR, but of course we consider on a case by case basis. No worries. @Divyansh013 is the i18n steward overall and can be tagged too. I think we are focusing now on the more basic tutorials, but since this translation has already been proposed and reviewed, I think it is fine to merge it when it's done. But if it should wait fo something, or if it duplicates any work, please let us know @Divyansh013 |
lirenjie95
left a comment
There was a problem hiding this comment.
Looks nice, approved!
|
Hi @lirenjie95, I've updated the translation following your feedback and added a few changes based on my own understanding. Could you please review it again?🥰 |
|
Looks good to me! Tagging @doradocodes to merge when you're next doing triage, and to determine whether cherrypicking to 2.0 is applicable here, I think this tutorial is the same in the 2 site versions but I'm not 100% sure |
8a29cd7 to
e9e8b53
Compare
Summary
This PR adds a full Chinese (zh-CN) translation of the Organizing Code with Functions tutorial.
Notes
(Waiting to link to a new issue?)