Added support for Kraken.com trade and ledger data - #25
Open
7cada wants to merge 2 commits into
Open
Conversation
…national). The header of the exported csv is: Uuid,Exchange,TimeStamp,OrderType,Limit,Quantity,QuantityRemaining,Commission,Price,PricePerUnit,IsConditional,Condition,ConditionTarget,ImmediateOrCancel,Closed
Owner
|
The Kraken support added is fine, thank you very much! But I don't understand how the Bittrex format can be so different than when added by anson-vandoren. Did they recently change the format? @anson-vandoren could you please also check the new format? We might need to add two different functions for adding Bittrex csv to not break the import of the old csv format. |
anson-vandoren
approved these changes
Jul 11, 2019
anson-vandoren
left a comment
anson-vandoren
left a comment
Contributor
There was a problem hiding this comment.
@probstj it looks like they did change the CSV format. I don't use Bittrex at the moment, but did log back in and check the format. The changes from @7cada look correct for the new format, and since even past transactions will export in the new format, I don't see any reason to maintain two different versions.
Thanks, @7cada !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Kraken support