[codex] enforce fail-fast status parsing#447
Draft
proboscis wants to merge 1 commit into
Draft
Conversation
f19a4c8 to
b7d2108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces the
inv-fail-fastinvariant while preserving legitimate historical issue data.open,in_progress/blocked->open,completed->resolved,canceled->closed; genuinely unknown non-empty issue statuses still fail.type: issuestill fail clearly.-sentinel is skipped instead of being parsed and panicking.logAndRepanic, semgrep guardrails for swallowedrecover()and discarded enum/parser errors, and amake lintfixture gate.Why
The issue
inv-fail-fastrequires failed operations to surface explicit errors and forbids unknown-accepting enum parse behavior. The first version was too strict for historical issue statuses and missing status frontmatter; this revision keeps legitimate historical data loadable while still rejecting genuinely unknown values.Validation
PATH=/home/kento/local/go/bin:$PATH ORCH_SAFE_CLI_TEST=1 go test ./...-> passedPATH=$HOME/.local/bin:$PATH make lint-> passedPATH=/home/kento/local/go/bin:$PATH ORCH_SAFE_CLI_TEST=1 go test ./internal/store/file -run TestListIssuesAcceptsLegacyAndEmptyStatuses-> passedIssue
Refs
inv-fail-fast