Merged
Conversation
ships
force-pushed
the
ships/add-sppl
branch
4 times, most recently
from
b27e394 to
459f934
Compare
KingMob
approved these changes
May 3, 2024
Contributor
KingMob
left a comment
KingMob
left a comment
There was a problem hiding this comment.
LGTM. I can confirm it builds with the SHA.
The GitHub (rather than PyPi) pinned source can be removed once it is released as 2.0.5 or greater on Pypi.
Schaechtle
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SPPL as a python package that will now be consumed from this repo like so:
This invocation will not work until this is merged -- for now, you must specify a sha:
Once this is merged, we can update documentation and finish probcomp/GenSQL.query#110 . Then once that is in, we can also open a PR to have an OCI image built here (or there, if we configure the whole OpenGen org with Docker Hub credentials, instaed of just this repo).