feat: separate OCI env-building from core packages#10
Merged
Conversation
ships
force-pushed
the
ships/oci-flake-separatee
branch
from
ed6fe91 to
bf010e9
Compare
zane
approved these changes
May 10, 2024
ships
force-pushed
the
ships/oci-flake-separatee
branch
2 times, most recently
from
9c4aba7 to
72f08f5
Compare
ships
force-pushed
the
ships/oci-flake-separatee
branch
from
72f08f5 to
f92f9a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a necessary refactor to prevent circular dependencies from forming in our Nix setup.
Individual tool repos rely on the main flake in this repo for libs and upstream dependencies, as introduced for example here. However, historically this repo also built the final OCI images for those tools, which is the intended flow for now because it is convenient to centralize the publish flow and because images actually correspond to environments, not tools.
These circular dependencies are not allowed. Fortunately, we can avoid this because the env/image components can simply consume the main
opengenflake (here done by relative path) and the tool repos remotely.Long term, this change will also make it easier to factor the OCI images more idiomatically by making them build images that directly correspond to a devShell derivation rather than separately listing their inputs. This way they can be guaranteed to work the same as a
nix developuse-case.This PR is a blocker for the linked one above.