fix(e2e): backport Get kubeconfig step to plugin-e2e workflow#167
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
fix(e2e): backport Get kubeconfig step to plugin-e2e workflow#167privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
The reusable plugin-e2e.yaml workflow was missing the robust Get kubeconfig step that the main-worktree copy has. This step handles multiple kubeconfig fallback paths (runner config, home kubeconfig, in-cluster service account) instead of assuming a pre-configured kubeconfig at a fixed path. This fixes startup failures in E2E runs where the runner pod could not locate a valid kubeconfig before deploying the E2E Headlamp instance. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the robust
Get kubeconfigstep from the main-worktree copy ofplugin-e2e.yamlinto the.githubreusable workflow.Problem
The reusable
plugin-e2e.yamlworkflow (invoked by all Headlamp plugin repos) was missing theGet kubeconfigstep. This step handles multiple kubeconfig fallback paths instead of assuming a pre-configured kubeconfig at a fixed path. E2E runs onrunners-privilegedescalation(self-hosted ARC runners) were failing withstartup_failurebecause the runner pod had no valid kubeconfig before attempting to deploy the E2E Headlamp instance.Fix
Added lines 40–75 (Get kubeconfig step) from the main-worktree version into
.github/workflows/plugin-e2e.yaml, inserting it betweenSetup kubectlandInstall dependenciessteps.Testing
startup_failurerecurrence; fix is considered verified if no furtherstartup_failureonrunners-privilegedescalationover 5 consecutive runs