fix(plugin-release): use artifacthub-pkg.yml name for tarball and archive-url#164
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
Conversation
…hive-url
- Update artifacthub-pkg.yml step: read name from artifacthub-pkg.yml
(authoritative) before falling back to package.json, so archive-url
matches the actual GitHub Release asset name for all 6 affected plugins
- Prepare release tarball step: mirror same logic for consistency
- Fixes PRI-336 and PRI-356
- Resolves: ArtifactHub was reading archive-url from committed artifacthub-pkg.yml
that pointed to a non-existent tarball (e.g. headlamp-argocd-{v}.tar.gz
instead of headlamp-argocd-plugin-{v}.tar.gz)
Contributor
Author
UAT Review — Pixel Patty ✅ APPROVEDValidation Method
Name mismatch verification (all 6 plugins confirmed)
What the fix does
Note on Playwright/UAT browser testingThis is a pure GitHub Actions workflow file with no UI or Headlamp plugin changes. No browser automation is applicable. CI (validate check) passed ✅. The workflow logic is sound and matches the authoritative source across all 6 plugins. UAT Result: APPROVED — Ready for QA review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Update artifacthub-pkg.ymlandPrepare release tarballsteps so both read the plugin name fromartifacthub-pkg.yml(authoritative) before falling back topackage.json.Root cause
After
headlamp-plugin package, the tarball is named using thenamefield fromartifacthub-pkg.yml— not thenamefrompackage.json. However, theUpdate artifacthub-pkg.ymlstep was readingPKG_NAMEfrompackage.json, causing the committedarchive-urlto point to a non-existent asset on GitHub Releases.Mismatch table (6 affected plugins)
@priv.../headlamp-argocd-plugin-{v}.tar.gzheadlamp-argocd-{v}.tar.gzkube-vip-{v}.tar.gzheadlamp-kube-vip-{v}.tar.gztns-csi-{v}.tar.gzheadlamp-tns-csi-plugin-{v}.tar.gzrook-{v}.tar.gzheadlamp-rook-plugin-{v}.tar.gzsealed-secrets-{v}.tar.gzheadlamp-sealed-secrets-{v}.tar.gzintel-gpu-{v}.tar.gzheadlamp-intel-gpu-{v}.tar.gzChanges
Update artifacthub-pkg.ymlstep: readsnamefromartifacthub-pkg.ymlviagrep "^name:"first; falls back topackage.jsononly ifartifacthub-pkg.ymlhas no name fieldPrepare release tarballstep: mirrors the same logic for consistencyFixes: PRI-336, PRI-356