fix(e2e): add plugin-name input to plugin-e2e.yaml reusable workflow#163
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
fix(e2e): add plugin-name input to plugin-e2e.yaml reusable workflow#163privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
Add required plugin-name input to enable per-plugin ConfigMap naming in the generalized deploy-e2e-headlamp.sh script. The e2e-namespace input is also added as optional (default: headlamp-dev) for consistency with per-repo overrides. Fixes PRI-956: E2E deploy step failure due to missing plugin-name in reusable workflow call from plugin repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
plugin-name(required) ande2e-namespace(optional) inputs to theplugin-e2e.yamlreusable workflow to enable per-plugin ConfigMap naming in the generalized deploy-e2e-headlamp.sh script.Root Cause
The reusable workflow was missing the
plugin-nameinput, causing thePLUGIN_NAMEenv var to be empty when the deploy-e2e-headlamp.sh script ran. This resulted in an empty ConfigMap name (headlamp--plugin) which caused E2E deploy step failures (startup_failure) for all plugin repos that call this workflow.Changes
.github/workflows/plugin-e2e.yaml: Addede2e-namespace(optional, defaultheadlamp-dev) andplugin-name(required) workflow inputsenvblock to useinputs.e2e-namespaceandinputs.plugin-nameAffected repos using this reusable workflow
After this PR merges, these repos will need their
e2e.yamlupdated to passplugin-name:headlamp-rook-plugin— currently pointing to stale branchhugh/add-pnpm-support-plugin-e2eheadlamp-sealed-secrets-plugin— points tomainheadlamp-tns-csi-plugin— points tomainheadlamp-kube-vip-plugin— points tomaincc @cpfarhood