ci-health-check.sh: append infra as private repo after dynamic discovery#162
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
ci-health-check.sh: append infra as private repo after dynamic discovery#162privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
Adds 'infra' to PLUGIN_REPOS after the discovery/fallback logic so the private infra repo is always included in CI/CD health checks regardless of which path populated PLUGIN_REPOS. Fixes: PRI-906 Fixes: PRI-488 Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
Author
|
Reviewers: @regression-regina QA review, @Pixel-Patty UAT. CI is running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
infratoPLUGIN_REPOSafter the dynamic discovery/fallback logic so the privateinfrarepo is always included in CI/CD health checks regardless of which path populatedPLUGIN_REPOS.Changes
.github/scripts/ci-health-check.sh— appendinfratoPLUGIN_REPOSafter discovery/fallback (3 lines added: comment + array append + blank line)Background
infratoPLUGIN_REPOSdirectly, but dynamic discovery overwrites that array, so the change had zero effectinfrais private, sovisibility == "public"filter in dynamic discovery never picks it upPLUGIN_REPOS_FALLBACKonly activates when discovery returns zero repos — wrong bucket for this fixAcceptance Criteria
infraappears inPLUGIN_REPOSafter the discovery/fallback logicPLUGIN_REPOS_FALLBACKis not modifiedFixes
Fixes PRI-906
Fixes PRI-488
Related: PRI-504
Reviewers
Co-Authored-By: Paperclip noreply@paperclip.ing