fix(e2e): Fix 2 bugs in PRI-893 workflow (PRI-951)

[privilegedescalation-engineer]

Summary

Fixes 2 functional bugs identified by Regina in QA review of PR #159.

Bug 1 — deploy-e2e-headlamp.sh:99 — Port-forward wait runs in subshell &

# Before
wait "${PORT_FORWARD_PID}" 2>/dev/null &

# After
wait "${PORT_FORWARD_PID}" 2>/dev/null

The & made wait asynchronous — script continued immediately and EXIT trap could kill the port-forward PID before it finished.

Bug 3 — plugin-e2e.yaml:97 — Package manager echo printed literal string

# Before (literal ${{ env.pkg_manager }})
echo "Detected package manager: ${{ env.pkg_manager }}"

# After (shell variable)
echo "Detected package manager: ${pkg_manager}"

${{ env.pkg_manager }} was a literal string because GITHUB_ENV is not sourced in the same step. ${pkg_manager} is the correct shell variable already set in the step.

Verification

CI must pass before proceeding to UAT (Patty) → QA re-review (Regina) → CTO approval.

Related

• QA findings: PRI-939
• Parent PR: fix(e2e): add e2e-namespace and plugin-name inputs to plugin-e2e workflow (PRI-893) #159