fix(ci): filter out non-approval reviews in dual-approval check#160
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
fix(ci): filter out non-approval reviews in dual-approval check#160privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dual-approval-check.yaml workflow was treating COMMENTED reviews (e.g. greptile bot) as rejection votes, causing false failures on PRs where the only greptile action was a comment.
Fix
Changed the approval check logic to only count reviews where state == "APPROVED". Filters out COMMENTED and CHANGES_REQUESTED.
Before: uses last review state (can be COMMENTED)
After: counts only APPROVED reviews
Impact
Fixes false failures on headlamp-kube-vip-plugin, headlamp-polaris-plugin, and any plugin repo where greptile or other non-approval bots leave comments.
Per PRI-826 cleanup.
cc @cpfarhood