fix(ci): post actionable comment on PR when dual approval is missing#158
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
fix(ci): post actionable comment on PR when dual approval is missing#158privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
privilegedescalation-engineer
Bot
force-pushed
the
hugh/improve-dual-approval-comment
branch
from
2c0c3f4 to
c7e5452
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the dual approval check fails, it now posts a comment directly on the PR naming the missing approvers (CTO, QA) and instructing them to submit an APPROVE review.
Before: Reviewers saw a red checkmark with no explanation of what was needed.
After: The workflow posts a clear comment explaining what approvals are required.
Changes:
GITHUB_OUTPUTforcto_approvedandqa_approvedstep outputsPost approval request commentstep that runs when approvals are missingScope: Affects all plugin repos using the dual-approval-check reusable workflow.
cc @cpfarhood