fix(ci-health-check): append infra as private repo after dynamic discovery#156
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
Conversation
After dynamic repo discovery and the fallback conditional, explicitly append the infra repo (which is private and thus invisible to the public-repos discovery query). This ensures infra is always scanned regardless of which path populated PLUGIN_REPOS. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infra(private repo) toPLUGIN_REPOSinfrais invisible to thevisibility == publicdiscovery query, so it must be added explicitlyPLUGIN_REPOS_FALLBACKis not modifiedAcceptance Criteria
infraappears inPLUGIN_REPOSafter the discovery/fallback logicPLUGIN_REPOS_FALLBACKis not modifiedContext
infradirectly toPLUGIN_REPOS_FALLBACK, which gets overwritten by the fallback conditionalcc @cpfarhood