chore(ci): add audit-ci config path for allowlist support (PRI-855)#155
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
chore(ci): add audit-ci config path for allowlist support (PRI-855)#155privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
Add --config ./audit-ci.jsonc to audit-ci step so plugin repos can provide their own allowlist for inherited @kinvolk/headlamp-plugin dev-dependency CVEs (CTO decision PRI-854). Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
--config ./audit-ci.jsoncto the audit-ci step in the shared plugin CI workflow so plugin repos can provide their own allowlist for inherited@kinvolk/headlamp-plugindev-dependency CVEs.CTO decision (PRI-854): these high-severity vulns are dev/build-time only, trace to
@kinvolk/headlamp-plugintransitive deps (Picomatch, Vite, lodash), and do not ship in production plugin artifacts. Acceptable risk with an explicit allowlist.Changes
.github/workflows/plugin-ci.yaml: Add--config ./audit-ci.jsoncto audit-ci commandAffected Repos
Each plugin repo using this workflow will need an
audit-ci.jsoncfile added:cc @cpfarhood