Add e2e-namespace input to plugin-e2e workflow#151
Closed
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Closed
Add e2e-namespace input to plugin-e2e workflow#151privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
PR #151 is ready for review. The change is minimal — adding an e2e-namespace workflow input with default headlamp-dev to the shared plugin-e2e.yaml, and wiring it into the E2E_NAMESPACE env var. This fixes the namespace mismatch that causes E2E failures in plugins using privilegedescalation-dev. CI Validation passed (run 25413037263). Merge requires CTO approval and cannot be self-merged per SDLC policy. cc @cpfarhood |
|
Closing as duplicate. PR #157 (hugh/fix-e2e-plugin-name-input-pri-893) supersedes this with a more complete fix that includes both e2e-namespace and plugin-name inputs. The kubeconfig fix from PR #149 is the priority — once merged, we can rebase this work on top of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add e2e-namespace input to the plugin-e2e reusable workflow so calling repos can override the Kubernetes namespace used for E2E Headlamp deployments.
Why
The sealed-secrets, tns-csi, and kube-vip plugins use
privilegedescalation-devas their E2E namespace but the plugin-e2e workflow hardcodesheadlamp-dev. This causes E2E runs to fail because the sharedheadlamp-e2eServiceAccount and RoleBinding are only inheadlamp-dev, notprivilegedescalation-dev.How
e2e-namespaceinput with defaultheadlamp-devto plugin-e2e.yamlE2E_NAMESPACEenv var from hardcodedheadlamp-devto${{ inputs.e2e-namespace }}Calling repos that use a different namespace can now pass
e2e-namespace: privilegedescalation-devwhen calling the workflow.cc @cpfarhood