Add plugin-name input and generalized E2E scripts to plugin-e2e.yaml#148
Open
privilegedescalation-engineer[bot] wants to merge 2 commits intomainfrom
Open
Add plugin-name input and generalized E2E scripts to plugin-e2e.yaml#148privilegedescalation-engineer[bot] wants to merge 2 commits intomainfrom
privilegedescalation-engineer[bot] wants to merge 2 commits intomainfrom
Conversation
- Add required plugin-name input to plugin-e2e.yaml workflow_call - Set PLUGIN_NAME env var from inputs.plugin-name in the e2e job - Add e2e-namespace input (default headlamp-dev) for namespace flexibility - Add pnpm support with packageManager field detection (corepack + caching) - Add Playwright browser cache/restore step for faster test runs - Add 3-retry Playwright install with exponential backoff - Add scripts/deploy-e2e-headlamp.sh and scripts/teardown-e2e-headlamp.sh with PLUGIN_NAME-based ConfigMap naming and mount path derivation Co-Authored-By: Paperclip <noreply@paperclip.ing>
- Add ::add-mask:: to prevent token exposure in logs - Replace silent warning with exit 1 on token generation failure - Issue 2 & 3 from QA findings on PR #148 Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes E2E startup_failure by adding a required
plugin-nameinput toplugin-e2e.yamland adding generalizeddeploy-e2e-headlamp.shandteardown-e2e-headlamp.shscripts to the shared workflow location.Changes
.github/workflows/plugin-e2e.yaml— addedplugin-name(required) ande2e-namespace(optional, defaultheadlamp-dev) inputs; setPLUGIN_NAMEenv var frominputs.plugin-namescripts/deploy-e2e-headlamp.shandscripts/teardown-e2e-headlamp.shin the.githubrepo; scripts derive ConfigMap name and mount path fromPLUGIN_NAMEenv varDetect package managerstep, pnpm corepack + caching, and 3-retry Playwright install with backoffRestore Playwright browser cachestep to speed up repeated runsRoot cause
The previous
plugin-e2e.yamlhad noplugin-nameinput, so callers that needed a non-default namespace (e.g.privilegedescalation-dev) or a specific plugin ConfigMap could not pass those through. The workflow referencedscripts/deploy-e2e-headlamp.shthat only existed in some plugin repos, not in the shared workflow location.Testing
PR workflow: https://github.com/privilegedescalation/.github/pull/compare/main...hugh/fix-e2e-plugin-name-input