ci: add pnpm support to plugin-e2e workflow#144
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
ci: add pnpm support to plugin-e2e workflow#144privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
- Detect package manager (pnpm vs npm) from pnpm-lock.yaml - Use Corepack when packageManager field is present - Add pnpm store caching - Update all steps to use correct package manager - Add e2e-namespace input for namespace flexibility Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
Author
UAT Review: APPROVEDReview type: Code-review UAT (CTO directive — no browser UI component) What changed: UAT verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates reusable workflow to support both npm and pnpm package managers.
Changes
pnpm: ENOENT: no such file or directory, open '/paperclip/patches/embedded-postgres@18.1.0-beta.16.patch'
at async open (node:internal/fs/promises:640:25)
at async Object.readFile (node:internal/fs/promises:1287:14)
at async createBase32HashFromFile (/paperclip/.cache/node/corepack/v1/pnpm/9.15.4/dist/pnpm.cjs:8816:23)
at async /paperclip/.cache/node/corepack/v1/pnpm/9.15.4/dist/pnpm.cjs:138813:17
at async /paperclip/.cache/node/corepack/v1/pnpm/9.15.4/dist/pnpm.cjs:138790:24
at async Promise.all (index 0)
at async pMapValue (/paperclip/.cache/node/corepack/v1/pnpm/9.15.4/dist/pnpm.cjs:138789:7)
at async _install (/paperclip/.cache/node/corepack/v1/pnpm/9.15.4/dist/pnpm.cjs:184714:134)
at async mutateModules (/paperclip/.cache/node/corepack/v1/pnpm/9.15.4/dist/pnpm.cjs:184673:23)
at async install (/paperclip/.cache/node/corepack/v1/pnpm/9.15.4/dist/pnpm.cjs:184599:45) or
up to date, audited 1 package in 373ms
found 0 vulnerabilities based on detected manager
Command "e2e" not found. or based on detected manager
Why
Several plugins (argocd, rook, kube-vip, sealed-secrets) use pnpm with field. The original workflow only supported npm. This update makes the workflow work for all plugin repos regardless of package manager choice.
Required reviewers
cc @cpfarhood
Co-Authored-By: Paperclip noreply@paperclip.ing