Tria socket & parameter cleanup#1175
Open
landinjm wants to merge 14 commits into
Open
Conversation
Contributor
Author
|
Core library compiles. Now there's just a bunch of annoying things to do to make sure the applications compile :( |
Contributor
Author
|
I also gave up on |
Contributor
Author
|
All the applications, compile. I ran a few in debug and everything seemed fine. Nucleation application is broken for unrelated reasons. See #1189 |
Contributor
Author
|
@fractalsbyx when do you think you'll get a chance to look this over? I'm hoping to get this out to get restarts and file input out tomorrow. |
Contributor
|
@landinjm I have been working on it today. I will submit a PR of changes prob tonight. |
Contributor
Author
|
Cool thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big PR since I decided to refactor/rewrite a lot of the parameters.
Fundamentally, one thing has changed in how we handle parameters from file. We now have a 5 step process.
The pre steps are necessary so I can use type polymorphism on the mesh classes. With the two extra steps we do a first pass over the parameter file before deciding what sections to check later on. I imagine these will also be useful for other things down the line.
Some of the parameter names have changed, but everything remains backwards compatible. The only breaking change is the access of mesh dimensions in applications. Now, to get the size of a rectangular you have to cast the mesh to whatever your mesh type is. We could make a safer version of this for users later on.
Additionally, size is no longer a member for rectangular meshes. There is only upper and lower bounds.
Closes #572
ParameterBasenow exists and see aboveCloses #606
ParameterBasenow exists and see aboveCloses #441
MeshBasenow exists and see aboveCloses #714 This can be set with the
UserInputParametersconstructorCloses #1118 This can be set with the
UserInputParametersconstructorCloses #959
MeshBasenow exists and see aboveCloses #671
Closes #502
Closes #713 'MeshBase` requires the definition of a distance function
Closes #146 Parameters are there. Restarts aren't