Skip to content

fix(compute): shape the room-booking author as the manifest schema expects - #8644

Merged
vanrensbird merged 1 commit into
latestfrom
fix/compute-manifest-author-field
Nov 1, 2026
Merged

vanrensbird merged 1 commit into
latestfrom
fix/compute-manifest-author-field

Conversation

@prisma-gremlin

@prisma-gremlin prisma-gremlin Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Merging #8637 took the /apps gallery down: the room-booking entry in compute/templates.json set "author": "Mohammed Obaid" as a plain string, but the site's manifest schema (prisma/web, apps/site/src/app/apps/_lib/catalog.ts) requires an object with name and url. The gallery validates the whole manifest in one pass and falls back to "Apps are unavailable" when any entry fails, so one bad field hid all five templates.

This restores the object shape:

"author": {
  "name": "Mohammed Obaid",
  "url": "https://github.com/mdobaid311"
}

The site refetches the manifest every 5 minutes, so the page recovers shortly after this lands on latest.

Validation

  • Parsed the fixed manifest against the site's actual zod schema: passes with all 5 templates (the pre-fix string value is rejected by the same check).
  • Diff is limited to the one field.

Known follow-up (not included)

tests/compute.test.ts still hardcodes the four original templates, and the room-booking template deviates from the test's standards (npm lockfile instead of bun.lock, packageManager: npm@10.9.4, composer:* scripts instead of compute:*, service.ts at the root instead of src/service.ts), so the compute test fails on latest and on this PR. This is why CI did not catch the bad field. Fixing it means either normalizing the template to the standard or teaching the test about community templates — happy to take that as a follow-up.

Created by Gremlin

Summary by CodeRabbit

  • Updates
    • The Room Booking template now includes the author’s name and a GitHub link in its attribution details. This provides more complete author information wherever the template’s attribution is displayed.

…pects

#8637 added the room-booking template with author as a plain string,
but the site's manifest schema requires an object with name and url.
The /apps gallery validates the whole manifest and falls back to
'Apps are unavailable' when any entry fails, so the string field hid
every template. Restore the object shape to bring the gallery back.

Co-Authored-By: Gremlin <gremlin[bot]@users.noreply.github.com>
@prisma-gremlin

prisma-gremlin Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Gremlin opened this pull request from a Slack conversation.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 21ced21 and 3e1cd8d.

Files selected for processing: 1
  • compute/templates.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The Room Booking template’s author value changed from a string to an object containing name and url fields.

Changes

Room Booking metadata

Layer / File(s) Summary
Author fields
compute/templates.json
The Room Booking template now stores the author’s name and GitHub URL in separate fields.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to 3e1cd

The manifest metadata fix is consistent with the site schema and is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the room-booking author shape to match the manifest schema.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@vanrensbird
vanrensbird merged commit d769725 into latest Nov 1, 2026
8 of 10 checks passed
@vanrensbird
vanrensbird deleted the fix/compute-manifest-author-field branch November 1, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant