Repository navigation
fix(compute): shape the room-booking author as the manifest schema expects - #8644
Conversation
…pects #8637 added the room-booking template with author as a plain string, but the site's manifest schema requires an object with name and url. The /apps gallery validates the whole manifest and falls back to 'Apps are unavailable' when any entry fails, so the string field hid every template. Restore the object shape to bring the gallery back. Co-Authored-By: Gremlin <gremlin[bot]@users.noreply.github.com>
|
Gremlin opened this pull request from a Slack conversation.
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Author fields compute/templates.json |
The Room Booking template now stores the author’s name and GitHub URL in separate fields. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Merge Risk: 
Minimal · up to 3e1cd
-
The manifest metadata fix is consistent with the site schema and is ready to merge.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Summary
Merging #8637 took the
/appsgallery down: the room-booking entry incompute/templates.jsonset"author": "Mohammed Obaid"as a plain string, but the site's manifest schema (prisma/web,apps/site/src/app/apps/_lib/catalog.ts) requires an object withnameandurl. The gallery validates the whole manifest in one pass and falls back to "Apps are unavailable" when any entry fails, so one bad field hid all five templates.This restores the object shape:
The site refetches the manifest every 5 minutes, so the page recovers shortly after this lands on
latest.Validation
Known follow-up (not included)
tests/compute.test.tsstill hardcodes the four original templates, and the room-booking template deviates from the test's standards (npm lockfile instead ofbun.lock,packageManager: npm@10.9.4,composer:*scripts instead ofcompute:*,service.tsat the root instead ofsrc/service.ts), so the compute test fails onlatestand on this PR. This is why CI did not catch the bad field. Fixing it means either normalizing the template to the standard or teaching the test about community templates — happy to take that as a follow-up.Created by Gremlin
Summary by CodeRabbit