Skip to content

fix(client): stop nested $transaction from mutating the caller's options object #30368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: v7
Choose a base branch
from
+25 −4
Open

fix(client): stop nested $transaction from mutating the caller's options object #30368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e205a11
fix(client): stop nested $transaction from mutating the caller's opti…
lazerg Sep 21, 2026
4389757
test(client): assert the transaction options object strictly
lazerg Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/client/src/runtime/getPrismaClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,9 +830,6 @@ Or read our docs at https://www.prisma.io/docs/concepts/components/prisma-client
if (activeScope !== itxContext.scopeId) {
throw new Error('Concurrent nested transactions are not supported')
}

// Re-use the underlying transaction in the engine by reusing the same transaction id.
options.newTxId = itxContext.txId
}
scopeStack.push(scopeId)

Expand All @@ -842,7 +839,8 @@ Or read our docs at https://www.prisma.io/docs/concepts/components/prisma-client
maxWait: options?.maxWait ?? this._engineConfig.transactionOptions.maxWait,
timeout: options?.timeout ?? this._engineConfig.transactionOptions.timeout,
isolationLevel: options?.isolationLevel ?? this._engineConfig.transactionOptions.isolationLevel,
newTxId: options.newTxId,
// Re-use the underlying transaction in the engine by reusing the same transaction id.
newTxId: isNested ? itxContext.txId : undefined,
}
let info: Transaction.InteractiveTransactionInfo<unknown>
try {
Expand Down
23 changes: 23 additions & 0 deletions packages/client/tests/functional/interactive-transactions/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,29 @@ testMatrix.setupTestSuite(
expect(users.map((u) => u.email)).toEqual([outerEmail1, outerEmail2].sort())
})

testIf(provider !== Providers.MONGODB)('sql: nested transaction does not mutate the options object', async () => {
const email1 = `user_${copycat.uuid(251)}@website.com`
const email2 = `user_${copycat.uuid(252)}@website.com`
const options = { maxWait: 5000, timeout: 5000 }

await prisma.$transaction(async (tx) => {
await tx.$transaction(async (tx2) => {
await tx2.user.create({ data: { email: email1 } })
}, options)
}, options)

expect(options).toStrictEqual({ maxWait: 5000, timeout: 5000 })

await prisma.$transaction(async (tx) => {
await tx.user.create({ data: { email: email2 } })
}, options)

const users = await prisma.user.findMany({
where: { email: { in: [email1, email2] } },
})
expect(users).toHaveLength(2)
})

testIf(provider !== Providers.MONGODB)('sql: enforce order for nested transactions', async () => {
const result = prisma.$transaction(async (tx) => {
const nested = tx.$transaction(async (tx2) => {
Expand Down