fix(postgres): preserve native contract query inference - #30342
sam-goodwin wants to merge 1 commit into
Conversation
Signed-off-by: Sam Goodwin <sam@alchemy.run>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (13)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PR adds literal aggregate descriptor inference, namespace-aware contract type derivation, PostgreSQL naming and namespace options, narrowed contract return types, and native PostgreSQL compile-time tests. ChangesNative contract inference
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete regression in native contract inference or PostgreSQL aggregate typing is established by the available evidence. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 10 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This was produced by AI, probably bad, LMK if you want changes or just re-do it. Problem is real |
Preserve query types when a TypeScript-authored contract is passed directly to
postgres({ contract }), without emitted declarations. Addresses the query-inference failures in #30341.Summary by CodeRabbit
New Features
Documentation