Skip to content

feat(adapter-mssql): make migration aware for use in prisma config adapter - #28262

Closed
tylerclendenin wants to merge 1 commit into
prisma:mainfrom
tylerclendenin:migration-aware-mssql-adapter
Closed

tylerclendenin wants to merge 1 commit into
prisma:mainfrom
tylerclendenin:migration-aware-mssql-adapter

Conversation

@tylerclendenin

Copy link
Copy Markdown
Contributor

Update the MSSQL adapter to be compatible with the prisma config file's defineConfig adapter option by implementing SqlMigrationAwareDriverAdapterFactory.

I added the connectToShadowDb method and updated the PrismaMssqlAdapter class to accept a release function which is called during dispose.

I used the adapter-pg as a template and adapted it.

Ref #9187

@jacek-prisma

Copy link
Copy Markdown
Contributor

Hi @tylerclendenin,
Making the adapter conform to the interface is not enough to enable its usage in the CLI - we also need to support it in our schema engine and this work is incomplete. I think it's better to not implement the interface for the time being until the MSSQL adapter is actually fully supported. Right now users attempting to use it in the CLI would see panics coming from the schema engine.

@tylerclendenin

Copy link
Copy Markdown
Contributor Author

Hi @tylerclendenin, Making the adapter conform to the interface is not enough to enable its usage in the CLI - we also need to support it in our schema engine and this work is incomplete. I think it's better to not implement the interface for the time being until the MSSQL adapter is actually fully supported. Right now users attempting to use it in the CLI would see panics coming from the schema engine.

So it's not just the MSSQL that is not supported, but none of the adapters will currently work because the engine only works with the Rust engine currently?

@tylerclendenin

tylerclendenin commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

@jacek-prisma depending on how long the integration for adapters takes for the prisma engine, this PR tiberius-rs/tiberius#378 for Tiberius should give parity for the MultiSubnetFailover feature. Do you know who might be able to review and integrate it? There does not seem to be much attention paid to it.

Or do you know a simple way I could add my own step to a pipeline to build my own Tiberius to be used by my own Prisma deployment?

@tensordreams
tensordreams changed the base branch from main to v7 July 21, 2026 12:11
@tensordreams
tensordreams changed the base branch from v7 to main July 21, 2026 15:16
@tensordreams

Copy link
Copy Markdown
Contributor

Hi @tylerclendenin — thanks for this, and apologies for the slow reply.

We're clearing the open PR backlog ahead of moving this codebase to a v7 branch, with the Prisma Next rewrite taking over main.

We are closing this one: as noted in review, conforming to the migration-aware interface is not sufficient without schema-engine support, and that work is incomplete.

Thanks for the time you put into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants