Repository navigation
fix: refresh Prisma 8 starters and deployment configuration - #125
Conversation
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Summary by CodeRabbit
WalkthroughGenerated projects now place Prisma Composer settings in Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The publishing smoke test checks the intended generated app on the minimum supported Node version. No actionable merge-blocking risk remains from the reviewed changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 10 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
PR preview published
|
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
There was a problem hiding this comment.
🔇 Additional comments (4)
scripts/smoke-node.mjs (2)
6-13: 📐 Maintainability & Code Quality | 💤 Low value
envis not merged with the full parent environment explicitly, and thenpm packcall omits it.
execamergesenvwithprocess.envby default, sonpm_config_engine_strictreaches the child processes. This is correct. Thenpm packcall passes noenv, so telemetry flags do not apply there. This is harmless fornpm pack.
1-66: LGTM!.github/workflows/publish.yml (1)
44-44: LGTM!Also applies to: 85-85, 254-254
.github/workflows/publish.yml-109-109 (1)
109-109: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Ad-hoc
npm install -g npm@11.6.0is flagged by zizmor.The install sits outside a lockfile. The version is pinned, so the practical risk is low. The pin is needed for trusted publishing. Accept the warning, or add a zizmor ignore with a reason.
Also applies to: 294-294
Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Essentials
- Run ID:
6873c2ef-d951-4639-b360-7207778fbd72
📒 Files selected for processing (2)
.github/workflows/publish.ymlscripts/smoke-node.mjs
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
Changes
8.0.0-rc.21(engine0.6.3), ORM8.0.0-rc.16, and Composer0.28.0.$libwith package imports as its migration guide specifies.baseUrlsetting.@elysia/nodeadapter package. Match Node engine ranges to the updated tools.composer: composer(...)section ofprisma.config.ts. Remove the retired separate Composer config; retain explicit deployment region and adapters for prebuilt apps.DATABASE_URLin Mongo's standalone ORM config, matching native init,.env.exampleand the runtime. Composer'sMONGODB_URLsecret is unchanged.Alchemy
2.0.0-beta.78and the template's Effect family4.0.0-rc.115remain aligned with published Composer0.28.0. Latest Alchemy uses Effect stable and cannot be substituted into that release independently. The CLI's own dependencies are unchanged. No compatibility shim, migration bypass, new test suite, or new CI workflow.Verified with the actual CLI
Fresh scaffolds used both PSL and TypeScript contracts. All 20 template/style combinations are verified in the cloud and locally. The first cloud matrix passed 19 of 20; TanStack/PSL was blocked by workspace database quota. After approved cleanup of older test projects, its generated deploy script passed without any code change. Checks require HTTP 200 and Alice/Bob/Carol on consecutive queries, plus a working home route.
Additional checks:
db init,db verify, build/typecheck and repeated queries against a real local Mongo replica set.0.13.5-pr.125.407.1additionally scaffolds, builds and typechecks Next.js/TypeScript (Bun), SvelteKit/PSL (Yarn) and TanStack/PSL (Bun). All three installed TypeScript6.0.3, and the packaged SvelteKit/TanStack configurations match the final source. Current-head preview0.13.5-pr.125.408.1additionally passed fresh Minimal/PSL scaffolding, skills setup, cloud deployment, build/typecheck and two live seeded queries on Bun 1.4.2.407.1subsequently passed their generated cloud deploy scripts and two live seeded queries: Next.js, SvelteKit, TanStack. The only source change between407.1and current408.1is a corrected comment and an existing-test assertion for TypeScript 6; template assets are unchanged.tsconfig(deprecatedbaseUrlremoved), passing typecheck and two live seeded queries against its existing cloud database. Its configuration matches the fresh final CLI scaffold.Verification notes
The test workspace
prisma-build-testran out of database slots during the initial matrix. Running the nativeprisma postgres createcommand confirmed:{ "code": "POSTGRES.API_ERROR", "why": "You have reached the maximum number of databases allowed for your plan.", "meta": { "status": 409, "apiCode": "quota-exceeded" } }Published Alchemy's database provider catches every
Conflictas a duplicate resource. It replaces this quota error withGenerated Prisma database '...' already exists but is not visible yet.No template workaround was added. The eight specifically approved oldercp21-{minimal,hono,elysia,nest}-{psl,ts}-eksrvttest projects were validated against local deployment records and remote workspace/name/id before permanent deletion. Local source and logs remain, and no plan was changed. TanStack/PSL and the current-head preview deployed successfully after freeing capacity.The remaining package-manager and published-preview cloud checks are complete and passed. The PR remains unmerged; no production release was made.
Docs checked
Scope
Cloud tests use Postgres in
prisma-build-test, on macOS ARM64 with Bun 1.4.0 or 1.4.2 / Node 26.7.0. npm/pnpm/Yarn checks cover representative combinations, not the full package-manager/OS cross-product. Windows CI checks creation/build, not Windows cloud deployment. Mongo was verified locally, not against an external cloud database. Deno remains local-only.CLI/framework telemetry was disabled for test runs. The cloud service still records test deployments. No merge, production release, upstream release or
latesttag change is part of this PR.