Skip to content

fix dbpool-manager not created bug #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
primadi merged 1 commit into from
Nov 30, 2025
Merged

fix dbpool-manager not created bug #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions core/deploy/loader/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/primadi/lokstra/core/deploy"
"github.com/primadi/lokstra/core/deploy/schema"
"github.com/primadi/lokstra/core/router"
"github.com/primadi/lokstra/serviceapi"
)

// Case-insensitive map lookup helpers
Expand Down Expand Up @@ -881,22 +882,15 @@ func setupNamedDbPools(registry *deploy.GlobalRegistry, config *schema.DeployCon
return nil
}

// Type assert to interface with required methods
type DbPoolManager interface {
SetNamedDsn(name, dsn, schema string)
GetNamedPool(name string) (any, error)
dpm, ok := deploy.Global().GetServiceAny("dbpool-manager")
if !ok || dpm == nil {
return fmt.Errorf("dbpool-manager service not found in registry")
}

poolManager, ok := registry.GetServiceAny("dbpool-manager")
if !ok || poolManager == nil {
log.Println("Warning: named-db-pools defined but dbpool-manager service not registered")
return nil
}

dbPoolManager, ok := poolManager.(DbPoolManager)
dbPoolManager, ok := dpm.(serviceapi.DbPoolManager)
if !ok {
return fmt.Errorf("dbpool-manager does not implement required interface (SetNamedDsn, GetNamedPool)")
return fmt.Errorf("dbpool-manager service does not implement serviceapi.DbPoolManager interface")
}

// Setup each pool
for poolName, poolConfig := range config.NamedDbPools {
// Extract DSN or build from components
Expand Down
Loading