Skip to content

Adding option to show fingerprint dialog#4

Open
anil-shrestha wants to merge 1 commit intopriezz:masterfrom
anil-shrestha:master
Open

Adding option to show fingerprint dialog#4
anil-shrestha wants to merge 1 commit intopriezz:masterfrom
anil-shrestha:master

Conversation

@anil-shrestha
Copy link
Copy Markdown

No description provided.

@anil-shrestha
Copy link
Copy Markdown
Author

any updates?

@priezz
Copy link
Copy Markdown
Owner

priezz commented May 6, 2020

@anil-shrestha , oops, have not noticed your PR, sorry...
Are you sure your change does not break anything when showFPDialog is false? I quickly ran through the changes and see that some code is not executed anymore while some new code is called unconditionally.

Could you please update the README?

@Muniru0
Copy link
Copy Markdown

Muniru0 commented May 16, 2020

I thought that not showing the fingerprint dialog was the reason for the package in the first place. The dialog not showing is intentional in my opinion. So that you can implement your own UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants